Load Logging configuration via Env, defaults to single #3458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the Logging configuration to be set via enviroment, for example, for development I want a single log, in forge I would prefer to log to the syslog so integrating papertrail is easier.
|
Just define this in your own app. |
|
@GrahamCampbell If Laravel is already providing .env abstraction for some variables, I do think that logging config would be good to be included by default. Laravel should provide a consistent interface for using Config and .env, I think that changing the logging configuration depending on the environment is a good use case, and something that makes sense, so it should be available by default as an .env option. |
|
@marcorivm You maybe right, but bombarding issue management with micro-"desires" (yes, they are not features) like this which mostly are subjective ideas, never helps. Please do this 2-second-long task in your apps. |
|
There no need to argue, a similar PR has been accepted and merged by Taylor #3551. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Logging configuration to be set via enviroment, for example, for development I want a single log, in forge I would prefer to log to the syslog so integrating papertrail is easier.