-
Notifications
You must be signed in to change notification settings - Fork 24.4k
Updating the log system with env variable #3551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The default shouldn't be changed from single. |
This PR does two things. |
Not true actually. |
@GrahamCampbell |
You might be using a system outside of laravel's control to process that single log file, like logrotate. |
Why using a system outside of laravel's control ? I'm sure a lot of artisans like to see their log files inside their apps by using log viewer packages. For example : LogViewer Package |
I'm sure they do. That's why it's configurable. |
👍 for .env variable, 👎 for daily log by default |
Yeah same here, I don't like the default but I don't think there is a default that would please everyone, on the other hand I would like it to be an env variable |
Is there any other good reason of using This is the benefits of using
|
Having it on the |
Yeh, you shouldn't change two things in a single PR. Please just make the env change here. |
@GrahamCampbell It's debatable and good to know how the others think about it. @brunogaspar @rkgrep Please, be more specific about your choice. |
It's easy, keep the
Don't take me wrong and i do see your point, but you need to see ours as well. Laravel makes it easy to start development with a minimum configuration required, once you go to production, just do your preparations like everyone should be doing, like set the env to production, set debug to false, in your case set the log to daily instead of single. Just because you fancy for daily during development, not everyone likes that, i'm included. |
Why the community is wasting time on not important details is beyond me. Who cares if its single or not?! We can change it with one single word edit. Simple. If you guys want to save everyone's times - yes, everyone's, as we all receive notifications for these PRs - please create Contribution Guidelines and ban all these nonsensical contributions to the package which would take 2-3 word replacements from any developer using it. Really tired of these nonsensical PRs. And please don't start another nonsense with notions like "Then unsubscribe-from/unwatch the project." If you think it's a contribution to Laravel, guess what, it is NOT! Go create something useful for God's sake: improve NoSQL driver for it or some other OAuth-2 integration, whatever you want... |
@shehi I'm here to contribute and share my ideas/opinions. Do you think this is a waste of time ? @brunogaspar thanks for sharing your opinion 👍 @GrahamCampbell I've rebased the PR. |
@arcanedev-maroc : I do mate (re this specific topic here). Nothing personal. You are not the first, and won't be the last anyway :( |
Check my repos : https://github.com/ARCANEDEV This may helps you : https://speakerdeck.com/mattstauffer/empathy-gives-you-superpowers 👍 |
👍 for .env. |
Updating the log system with env variable
The
single
log system is only useful in dev/local environment.