<label> element #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My English is not the best, so I added only a basic comment to $labels and label(). Feel free to complete them if needed! |
|
This looks good! I'll merge it in when I get home tonight. Thanks for your contribution! Only thing I see is you misspelled "label" on your property description. |
|
Great. I'm glad to help. Note the 2nd param for label() is mandatory since there's no reason to have a label without name. |
taylorotwell
added a commit
that referenced
this pull request
Jun 14, 2011
Added <label> element to form class. Input elements will automatically receive the ID of the corresponding label element if one exists.
zoe-edwards
pushed a commit
to zoe-edwards/laravel
that referenced
this pull request
Oct 14, 2013
Update src/Illuminate/Events/Dispatcher.php
This was referenced Sep 14, 2014
This was referenced Mar 24, 2016
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Merge changes
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Rebase with release 2.0.10
sl0wik
added a commit
to sl0wik/laravel
that referenced
this pull request
Oct 4, 2023
…river Firestore session driver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the small things I'd like to see in Laravel, support for the label element in the Form class.
I added it and would like to hear your thoughts on it. It can be used as other Form methods.
The problem is that to work properly, allowing people to select the input field by clicking on the label, the input needs an id. Which is not added by default, but can be passed as an array. What about detect if there is an label for that input and automatically add the id?