Use APP_TIMEZONE environment variablee in application config #4325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be handy if default `config/app.php` will have `APP_TIMEZONE` environment variable.
|
You can add this to your own project. |
|
Every PR's change can be added to your own project. |
|
We don't need every config variable available as an env variable because of one or two people's usecase of wanting completely different database collation or using different timezones. The config is meant to be altered by you, it's not hard to add the env in stuff you want to change. I personally only change what actually needs changed in different environments and it's a hassle having to remove everyone's edge use cases and change back to what actually matters. |
This was referenced Apr 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be handy if default
config/app.phpwill haveAPP_TIMEZONEenvironment variable.