Skip to content

[5.8] Prefix redis database connection by default #4982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2019
Merged

[5.8] Prefix redis database connection by default #4982

merged 2 commits into from
Apr 5, 2019

Conversation

DivineOmega
Copy link
Contributor

This PR prefixes the redis database connection by default to mitigate multiple sites on the same server potentially sharing the same queued jobs. It uses similar logic to that which is used for creating the cache prefix.

@DivineOmega
Prefix redis database connection by default to mitigate multiple site…
c8bc79e 
…s on the same server potentially sharing the same queued jobs
@driesvints driesvints changed the title Prefix redis database connection by default [5.8] Prefix redis database connection by default Apr 4, 2019
it-can
it-can reviewed Apr 4, 2019
View reviewed changes
@DivineOmega DivineOmega mentioned this pull request Apr 5, 2019
Closed
@taylorotwell taylorotwell merged commit 3537492 into laravel:master Apr 5, 2019
@DivineOmega
Copy link
Contributor Author

Thanks.

@DivineOmega DivineOmega deleted the patch-1 branch April 5, 2019 15:12
@fitztrev
Copy link

fitztrev commented Apr 5, 2019

I just tried this and looked at the results in Redis. There might be a couple issues.

  1. Horizon overrides the config and sets its own prefix. So whatever prefix is set under this config is ignored and there may still end up being conflicts between sites for horizon:* keys if they don't also have unique horizon.prefix configs.

  2. In Redis, keys are now showing up as:

laravel_databaselaravel_cache:foo     <-- for a cached value
laravel_databasequeues:default:job    <-- for a queued job

Should the prefix be appended with an underscore?

@ludo237
Copy link

ludo237 commented Apr 6, 2019

Interesting @fitztrev, @DivineOmega what do you think?

realodix added a commit to realodix/urlhub that referenced this pull request Apr 8, 2019
@realodix
Prefix redis database connection by default to mitigate multiple site…
c62435b 
…s on the same server potentially sharing the same queued jobs

laravel/laravel#4982
realodix added a commit to realodix/urlhub that referenced this pull request Apr 8, 2019
@realodix
Use Str class instead of helper function
bb6c9ad 
laravel/laravel#4982
@DivineOmega
Copy link
Contributor Author

@fitztrev @ludo237 @gerardnll I agree with adding an additional underscore to the prefix. I'll tweak this.

@DivineOmega DivineOmega mentioned this pull request Apr 8, 2019
Merged
@DivineOmega
Copy link
Contributor Author

@fitztrev @ludo237 @gerardnll I've opened a PR for this here: #4986

This was referenced May 7, 2019
Open
Open
Open
Open
@kkomelin kkomelin mentioned this pull request Jul 30, 2019
Closed
@arjanwestdorp arjanwestdorp mentioned this pull request Sep 16, 2019
Merged
@tlaverdure tlaverdure mentioned this pull request Nov 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@it-can it-can it-can left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DivineOmega @fitztrev @ludo237 @it-can @gerardnll @taylorotwell