Adding an underscore to cache prefix will create keys like this: local_database_local_cache_:<key>. I would just add ':' to config/database.php prefix so keys will look like local_database:local_cache:<key>.

Also, why not laravel_database:laravel_cache:<key> instead?

@gerardnll We need to use a suffix that all potential cache systems definitely support. I would imagine underscore is far more supported than a colon may be, especially if you consider file system based caches.

Thanks for merging @taylorotwell. 👍

@gerardnll I don't want to be that guy but as always: those files are editable by the dev-team after all, so it's up to them.

The new part of this merge, and the previous one, is the exposure of the prefix option which is huge imo

@gerardnll I don't want to be that guy but as always: those files are editable by the dev-team after all, so it's up to them.

The new part of this merge, and the previous one, is the exposure of the prefix option which is huge imo

Yep, I'll just overwrite that config var.

@gerardnll We need to use a suffix that all potential cache systems definitely support. I would imagine underscore is far more supported than a colon may be, especially if you consider file system based caches.

Only Redis, Memcached, database and Dynamo and APC use prefixes.

The cache one should not be appended with the underscore. Those keys are now:

laravel_database_laravel_cache_:<key>

The cache one should not be appended with the underscore. Those keys are now:

laravel_database_laravel_cache_:<key>

Yes, that's what I was pointing out in my first comment...

@DivineOmega was there a reason you changed the cache prefix config?

@fitztrev I was not aware that the cache key prefix had a : automatically appending to it.

@gerardnll We need to use a suffix that all potential cache systems definitely support. I would imagine underscore is far more supported than a colon may be, especially if you consider file system based caches.

Only Redis, Memcached, database and Dynamo and APC use prefixes.

Ah, that makes sense. I wasn't aware the cache prefix was only applied to certain cache drivers..

@gerardnll I'm on it. :)

@fitztrev @gerardnll PR to remove the underscore from the cache prefix is here: #4987.

I think laravel:cache:<key> is a better naming convention. As discussed above, I see no reason not to use it.