</form> in form class #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll merge this in later today. |
|
@taylor, is it needed to have PHP_EOL at the end of the string in this case? |
|
Didn't think about that. Do you want me to update it? |
|
Well, I came to know PHP_EOL reading Laravel's code. Since it's newline character that is cross-platform-compatible I think it's to good to have it. Go ahead! |
|
Yeah go ahead and put one. Thanks! On Jun 14, 2011, at 11:27 AM, pedroborgesreply@reply.github.com wrote:
|
|
I did, see my previous commit ^^ |
taylorotwell
pushed a commit
that referenced
this pull request
Jan 5, 2013
This was referenced Sep 14, 2014
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Translation it
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Nov 24, 2017
Apply fixes from StyleCI
sl0wik
added a commit
to sl0wik/laravel
that referenced
this pull request
Oct 4, 2023
Firestore cache driver
flap152
pushed a commit
to flap152/laravel
that referenced
this pull request
Jan 29, 2024
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My IDE or any editor like's to pretend there are errors when I use the form open method but then put an html
</form>. I figured this would fix that problem. You open the form with PHP, why not close it with PHP.I did this on your develop branch. Not sure if thats the best practice when sending pull requests. Never done this before.