Skip to content

cleanup unit tests #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gdementen opened this issue Jan 4, 2017 · 4 comments
Closed

cleanup unit tests #26

gdementen opened this issue Jan 4, 2017 · 4 comments
Labels
cleanup priority: low tests

Comments

@gdementen
Copy link
Contributor

we should rewrite most LArray unit tests using small-ish arrays created using ndtest() instead of the current demo-related examples.
@alixdamman alixdamman changed the title cleanup unit tests cleanup unit tests and use pytest Apr 25, 2017
@alixdamman alixdamman changed the title cleanup unit tests and use pytest cleanup unit tests May 1, 2017
@alixdamman
Copy link
Collaborator

cleanup + use a more pytest like syntax --> https://docs.pytest.org/en/latest/assert.html

@gdementen
Copy link
Contributor Author

we have 2 separate issues here: the "content" of the tests (ie use smaller test arrays mostly created using ndtest) and the "format" of the tests (ie pytest syntax instead of unittest syntax). We can of course tackle both at the same time, but we do not have to.

@alixdamman
Copy link
Collaborator

issue #237 should be fixed in the same time.

@gdementen gdementen mentioned this issue Feb 21, 2018
Merged
@alixdamman alixdamman modified the milestones: all, nice_to_have Mar 7, 2018
@alixdamman
Copy link
Collaborator

alixdamman commented Apr 3, 2018 •
edited
Loading

to convert nosetests to pytest :

alixdamman referenced this issue Apr 6, 2018
@alixdamman
convert tmpdir (which is a LocalPath object) to a string otherwise os…
79605cc 
….path.join will fail using Python <= 3.5
@alixdamman alixdamman mentioned this issue Jun 1, 2018
Merged
@gdementen gdementen removed this from the nice_to_have milestone Aug 1, 2019
gdementen added a commit to gdementen/larray that referenced this issue Feb 14, 2023
@gdementen
TEST: cleanup unit tests by using ndtest based arrays (closes larray-…
f7d557a 
…project#26)

also self.assertEqual(a, b) -> assert a == b in commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup priority: low tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gdementen @alixdamman