sigc++config.h.*: Update and clean up a bit for Visual Studio #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already need Visual Studio 2017 or later, so this part is not used at all here.
This still applies here today, sadly, so make the comment clearer.
Sorry, I don't understand your question. The latest release of libsigc++-2.x |
|
Hi @kjellahl, Sorry, I did indeed mean to say "any libsigc++-2.x release after 2.12.x, i.e. 2.13.x or later". Thanks though. |
|
I don't think there will be a 2.13.x or later, but there is no guarantee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This attempts to clean up and update these
sigc++config.h.*files a bit in regards to Visual Studio:noexcept, since we require Visual Studio 2017 or later for libsigc++-3.x.warning C4251in the comments still applies today, and attempting to try to see whether we can exportstd::listcan risk breaking ABI, so update the comment there.Do we still have any libsigc++-2.x versions beyond 2.12? If so, I think we could just drop VS2013 support, since the latest C++11 releases of items that use libsigc++-2.x would actually require VS2015 (or even VS2017 for libxml++-3.x) or later.
With blessings, thank you!