Also it seems libjxl now has JxlEncoderSetICCProfile() method, so it can be used instead of the logic above when input files have a profile. As I can see currently ICC profiles are not handled for JXL.

Hi @f1ac,

Sure, this all sounds good. Let's tag this as an enhancement for 8.13.

OK, done! I've made a PR here:

#2815

Any testing very welcome.

It looks like libjxl now has EXIF, XMP etc. as well, so we should also add support for them, and perhaps bump the minimum supprted libjxl version.

@jcupitt Are there any nightly builds for windows? I gave up trying to compile the library, so can't test this w/o binaries unfortunately.

With WSL2 it should be a one-liner to build from source now:

https://github.com/libvips/build-win64-mxe

Just:

./build.sh all --nightly

To build git master libvips for windows. It does take a while :(

Of course, having looked at this, there's no simple way to build a specific commit. I'll try to add this feature.

I've managed to build vips master, then changed the branch in plugins/nightly/overrides.mk to "vips-all_GH_CONF := libvips/libvips/branches/add-more-libjxl-metadata". The second time it was much faster, but I guess it did not pick up the new branch as resulting JXL files are identical to the ones converted with v8.12.2. I either need to clean up build folder or the overrides do no work.

If you want to test specific commits or branches, I think you also need to change nightly_version here:
https://github.com/libvips/build-win64-mxe/blob/4ddf96c4c152f129d320d27fcf11ade9f9f73e65/build/build.sh#L133
to:

nightly_version=$(wget -q -O- 'https://api.github.com/repos/libvips/libvips/git/refs/heads/add-more-libjxl-metadata' | sed -n 's#.*"sha": "\([^"]\{7\}\).*#\1#p' | head -1)

(to test the add-more-libjxl-metadata branch)

or just:

nightly_version="bb8d107445759cb5db2c15bd5ea3335905a2e817"

(to test commit bb8d107)

I'll try to add support for the --commit option tomorrow (see libvips/build-win64-mxe#44).

I posted a sample output image in linear space here: #2815 (comment)

There's an ICC profile too.

@jcupitt GIMP shows both jpg and jxl do not have embedded ICC, jpeg has EXIF data.

Sorry! I messed up. Let me try again.