Skip to content

try to make cgifsave easier to read #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2022
Merged

try to make cgifsave easier to read #2853

merged 2 commits into from
Jun 12, 2022

Conversation

jcupitt
Copy link
Member

@jcupitt jcupitt commented Jun 10, 2022 •
edited
Loading

And fix a few memory errors and leaks with reoptimise.

Speed seems the same.

$ valgrind vipsthumbnail 3198.gif[n=-1] -o vips-13.gif --size 224
$ valgrind vipsthumbnail 3198.gif[n=-1] -o vips-13.gif[reoptimise] --size 224

Both pass cleanly. You can use --vips-info to get a bit of debugging output:

$ time vips copy sample.gif[n=-1] x.gif[reoptimise] --vips-info
VIPS-INFO: 18:17:19.094: cgifsave: 301 frames
VIPS-INFO: 18:17:19.094: cgifsave: 215 unique palettes

real	0m17.583s
user	0m24.593s
sys	0m0.477s

@jcupitt
try to make cgifsave easier to read
ca9ed4c 
and fix a few memory errors
This was referenced Jun 10, 2022
Closed
Closed
@kleisauke kleisauke mentioned this pull request Jun 11, 2022
Merged
@jcupitt jcupitt merged commit 7fbdb01 into master Jun 12, 2022
@jcupitt jcupitt deleted the refactor-cgifsave branch June 12, 2022 10:25
@dloebl dloebl mentioned this pull request Jun 13, 2022
Closed
@DarthSim DarthSim mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcupitt