threadpool: prefer use of dedicated GLib atomic operations #4123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleisauke
added a commit
to libvips/build-win64-mxe
that referenced
this pull request
Aug 27, 2024
This comment was marked as resolved.
This comment was marked as resolved.
d12db7a to
4a711f7
Compare
That is: `g_atomic_int_add(..., 1)` -> `g_atomic_int_inc(...)` `g_atomic_int_add(..., -1)` -> `g_atomic_int_dec_and_test(...)` Additionally, turn the exit count into a proper flag, enabling the use of a single atomic compare-and-exchange operation that resets the flag only when it is set.
4a711f7 to
5ba5424
Compare
|
Oooof sorry for the delay. Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is:
g_atomic_int_add(..., 1)->g_atomic_int_inc(...)g_atomic_int_add(..., -1)->g_atomic_int_dec_and_test(...)Additionally, turn the exit count into a proper flag, enabling the use of a single atomic compare-and-exchange operation that resets the flag only when it is set.
Should be considered as a non-functional change.