[Offload] Run unit tests as a part of check-offload #156675
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add a dependnecy on the unit tests on the main check-offload test suite. This matches what the other projects do, pass `llvm-lit` to the directory to only run the lit tests, use the `check-offload-unit` for only the unit tests.
|
@llvm/pr-subscribers-offload Author: Joseph Huber (jhuber6) ChangesSummary: Full diff: https://github.com/llvm/llvm-project/pull/156675.diff 1 Files Affected:
diff --git a/offload/test/CMakeLists.txt b/offload/test/CMakeLists.txt
index 711621de9075d..c317394ada66f 100644
--- a/offload/test/CMakeLists.txt
+++ b/offload/test/CMakeLists.txt
@@ -61,7 +61,7 @@ add_offload_testsuite(check-offload
"Running libomptarget tests"
${LIBOMPTARGET_LIT_TESTSUITES}
EXCLUDE_FROM_CHECK_ALL
- DEPENDS llvm-offload-device-info omptarget ${OMP_DEPEND} ${LIBOMPTARGET_TESTED_PLUGINS}
+ DEPENDS llvm-offload-device-info omptarget ${OMP_DEPEND} ${LIBOMPTARGET_TESTED_PLUGINS} check-offload-unit
ARGS ${LIBOMPTARGET_LIT_ARG_LIST})
# Add liboffload unit tests - the test binary will run on all available devices
|
jplehr
approved these changes
Sep 3, 2025
|
It appears that this breaks the ability to do Leaving this here as an observation and something we likely want to fix at some point. |
Hm, maybe the other targets do something slightly different to register their unit tests. Right now we just do |
|
This change broke standalone builds. I think it is because Other tests are using |
Yeah, I think the offload unittests are using |
|
With #157253 I was able to use a and so on. The complete list is: …leaving 5 tests actually passing. |
How are you configuring it? I think there might be something that goes wrong if you don't have all the plugin enabled and the tests don't handle it properly. |
(this is from build log, so don't worry about missing quotes) |
|
I'm going to assume that this causes some |
|
Do you want me to file a separate bug for that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a dependnecy on the unit tests on the main check-offload test suite.
This matches what the other projects do, pass
llvm-litto thedirectory to only run the lit tests, use the
check-offload-unitforonly the unit tests.