Skip to content

[AVR] Refactor ADIW/SBIW/MOVW instruction descriptions (NFCI) #156876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 5, 2025
Merged

[AVR] Refactor ADIW/SBIW/MOVW instruction descriptions (NFCI) #156876

merged 4 commits into from
Sep 5, 2025

Conversation

s-barannikov
Copy link
Contributor

@s-barannikov s-barannikov commented Sep 4, 2025 •
edited
Loading

  • Remove custom decoders for these instructions
  • Instead, provide decoders for DREGS/IWREGS register classes
  • Change register pair encodings to simplify instruction descriptions
  • Add/fix a few clarifying comments

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@s-barannikov s-barannikov force-pushed the avr-decoder-3-reg-pairs branch from 4888336 to cdf546f Compare September 4, 2025 12:51
@s-barannikov s-barannikov changed the title [AVR] Refactor ADIW/SBIW/MOVW instruction descriptions [AVR] Refactor ADIW/SBIW/MOVW instruction descriptions (NFCI) Sep 4, 2025
@s-barannikov s-barannikov force-pushed the avr-decoder-3-reg-pairs branch 3 times, most recently from 71dc9df to 2ceb471 Compare September 4, 2025 16:14
benshi001
benshi001 reviewed Sep 5, 2025
View reviewed changes
@s-barannikov s-barannikov force-pushed the avr-decoder-3-reg-pairs branch from 2ceb471 to b826233 Compare September 5, 2025 08:21
benshi001
benshi001 reviewed Sep 5, 2025
View reviewed changes
@s-barannikov
[AVR] Refactor ADIW/SBIW/MOVW instruction descriptions
4cd8b31 
* Remove custom decoders for these instructions
* Instead, provide decoders for DREGS/IWREGS register classes
* Change register pair encodings to simplify instruction descriptions
@s-barannikov
Add a comment about acceptable registers
4cd24b0
@s-barannikov
Revert naming changes
867b886
@s-barannikov s-barannikov force-pushed the avr-decoder-3-reg-pairs branch from b826233 to 867b886 Compare September 5, 2025 10:12
@benshi001 benshi001 self-requested a review September 5, 2025 10:15
benshi001
benshi001 approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@benshi001 benshi001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-barannikov s-barannikov merged commit f28f1c2 into llvm:main Sep 5, 2025
9 checks passed
@s-barannikov s-barannikov deleted the avr-decoder-3-reg-pairs branch September 5, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benshi001 benshi001 benshi001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-barannikov @benshi001