Skip to content

Deprecate event rule engine config #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2024
Merged

Deprecate event rule engine config #1587

merged 3 commits into from
Dec 5, 2024

Conversation

joe4dev
Copy link
Member

@joe4dev joe4dev commented Dec 4, 2024

EVENT_RULE_ENGINE deprecated in localstack/localstack#11964

New Python implementation: localstack/localstack#11960

@joe4dev joe4dev requested a review from bentsku December 4, 2024 16:47
@joe4dev joe4dev self-assigned this Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

🎊 PR Preview has been successfully built and deployed to https://localstack-docs-preview-pr-1587.surge.sh 🎊

bentsku
bentsku approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup! Just a typo and question around what to link, but it can be merged as is if the typo if fixed 😄

joe4dev and others added 2 commits December 5, 2024 13:46
@joe4dev @bentsku
Fix typo
545f1b5 
Co-authored-by: Ben Simon Hartung <42031100+bentsku@users.noreply.github.com>
@joe4dev
Update links
799adbc
@joe4dev
Copy link
Member Author

joe4dev commented Dec 5, 2024

nice cleanup! Just a typo and question around what to link, but it can be merged as is if the typo if fixed 😄

Thanks 👍
Updated to link both :)

@joe4dev joe4dev merged commit 81d363e into main Dec 5, 2024
5 checks passed
@joe4dev joe4dev deleted the deprecate-event-rule-engine-config branch December 5, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku approved these changes

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@maxhoheiser maxhoheiser Awaiting requested review from maxhoheiser maxhoheiser is a code owner

Assignees

@joe4dev joe4dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe4dev @bentsku