-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
fix: replace DEVELOP
mode
#11285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: replace DEVELOP
mode
#11285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
commented
Jul 30, 2024
thrau
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just one comment related to the code organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the migration to the new runtime (PR 1 adding the new runtime, PR 2 removing the old runtime), the
DEVELOP
live debugging functionality was missed. This workflow, coupled with usinglocalstack.dev.run
is crucial for debugging parts of LocalStack that only work when run from a container, e.g. testing inter-container Docker networking via services.Changes
DEVELOP
functionality back, including launching thedebugpy
debuggerDEVELOP=1
WAIT_FOR_DEBUGGER=1
debugpy
withDEVELOP_PORT
(default: 5678)localstack.dev.run
where community only entrypoints were not being mounted from the correct place (when launched from a community checkout)localstack.dev.run
where community and pro entrypoints were not being mounted from the correct place (when launched from a pro checkout)HostPaths
to access source code checkout paths on the hostTesting
master
localstack.dev.run --mount-entrypoints
localstack.dev.run --mount-entrypoints
localstack.dev.run --mount-entrypoints --develop
debugpy
is being installed, and is available on port 5678