Skip to content

Remove virtualenv dependency from docker build #11794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dfangl
Copy link
Member

@dfangl dfangl commented Nov 6, 2024

Motivation

We currently install virtualenv into its own layer for the only purpose to create a virtual environment.
However, we can do that just as easily with python -m venv .venv. Virtualenv is a nice tool, but its features do not seem to be needed in our docker build.

This change reduces the layers by 1, and should decrease the image size a tad, and we get one less unpinned dependency.

The change should not have any impact on our users, but users might depend on "virtualenv" being installed in init scripts (although unlikely), so I would like to release it with 4.0 as breaking change.

Changes

  • Remove virtualenv installation from docker build

… create a venv, which can be done using internal tooling as well
@dfangl dfangl added this to the 4.0 milestone Nov 6, 2024
@dfangl dfangl added the semver: major Breaking changes which can be included in a major release only label Nov 6, 2024
@dfangl dfangl self-assigned this Nov 6, 2024
@dfangl dfangl requested a review from alexrashed November 6, 2024 18:01
@localstack-bot
Copy link
Collaborator

Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time.

@dfangl dfangl changed the base branch from master to release/v4 November 6, 2024 18:02
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch! To be honest, I would actually not declare this as a major change, since we change the set of our dependencies all the time. ;)

@alexrashed alexrashed mentioned this pull request Nov 7, 2024
9 tasks
@dfangl dfangl added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed semver: major Breaking changes which can be included in a major release only labels Nov 7, 2024
@dfangl dfangl marked this pull request as ready for review November 7, 2024 13:25
@dfangl dfangl merged commit defeee1 into release/v4 Nov 7, 2024
24 of 27 checks passed
@dfangl dfangl deleted the image/remove-virtualenv branch November 7, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants