Remove virtualenv dependency from docker build #11794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… create a venv, which can be done using internal tooling as well
|
Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time. |
alexrashed
approved these changes
Nov 7, 2024
alexrashed
pushed a commit
that referenced
this pull request
Nov 8, 2024
joe4dev
pushed a commit
that referenced
this pull request
Nov 12, 2024
dfangl
added a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
dominikschubert
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently install
virtualenvinto its own layer for the only purpose to create a virtual environment.However, we can do that just as easily with
python -m venv .venv. Virtualenv is a nice tool, but its features do not seem to be needed in our docker build.This change reduces the layers by 1, and should decrease the image size a tad, and we get one less unpinned dependency.
The change should not have any impact on our users, but users might depend on "virtualenv" being installed in init scripts (although unlikely), so I would like to release it with 4.0 as breaking change.
Changes