Skip to content

v4 release PR #11804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 14, 2024
Merged

v4 release PR #11804

merged 9 commits into from
Nov 14, 2024

Conversation

alexrashed
Copy link
Member

@alexrashed alexrashed commented Nov 7, 2024 •
edited by bentsku
Loading

This PR collects breaking changes which will be released in LocalStack v4.
An announcement on the release timeline and the breaking changes can be found here: #11803

Changes

Documentation

All of these changes should see pendants in the docs repo / this PR: localstack/docs#1547

Useful links

@alexrashed alexrashed added the semver: major Breaking changes which can be included in a major release only label Nov 7, 2024
@alexrashed alexrashed added this to the 4.0 milestone Nov 7, 2024
@localstack-bot
Copy link
Collaborator

Currently, only minor and patch changes are allowed on master. Your PR labels (semver: major) indicate that it cannot be merged into the master at this time.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files    2 suites   4m 32s ⏱️
421 tests 369 ✅  52 💤 0 ❌
842 runs  738 ✅ 104 💤 0 ❌

Results for commit bdc2af8.

♻️ This comment has been updated with latest results.

@bentsku
Copy link
Contributor

bentsku commented Nov 7, 2024 •
edited
Loading

It seems we lost a commit in this branch, maybe due to the rebasing: #11754

The tests are being executed here: https://app.circleci.com/pipelines/github/localstack/localstack/29278/workflows/0a3943be-2a89-4dc9-8f56-955f52b45729/jobs/258051

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ± 0      2 suites  ±0   1h 43m 27s ⏱️ -1s
3 525 tests  - 16  3 132 ✅ +5  393 💤  - 21  0 ❌ ±0 
3 527 runs   - 16  3 132 ✅ +5  395 💤  - 21  0 ❌ ±0 

Results for commit bdc2af8. ± Comparison against base commit 3de5aa9.

This pull request removes 16 tests. 
tests.aws.services.s3.test_s3.TestS3BucketPolicies ‑ test_access_to_bucket_not_denied
tests.aws.services.s3.test_s3_list_operations.TestS3ListMultipartUploads ‑ test_list_multipart_uploads_parameters
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy ‑ test_aws_sdk_task
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy ‑ test_aws_sdk_task_delete_s3_object
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy ‑ test_default_logging_configuration
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy ‑ test_multiregion_nested[statemachine_definition0-eu-central-1]
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy ‑ test_multiregion_nested[statemachine_definition0-eu-west-1]
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy ‑ test_multiregion_nested[statemachine_definition0-us-east-1]
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy ‑ test_multiregion_nested[statemachine_definition0-us-east-2]
tests.aws.services.stepfunctions.legacy.test_stepfunctions_legacy.TestStateMachine ‑ test_create_choice_state_machine
…
This pull request skips 11 and un-skips 16 tests. 
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_http_integration_with_path_request_parameter
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_lambda_proxy_integration[/lambda/foo1]
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_lambda_proxy_integration[/lambda/{test_param1}]
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_lambda_proxy_integration_any_method
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_lambda_proxy_integration_any_method_with_path_param
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_gateway_lambda_proxy_integration_with_is_base_64_encoded
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_api_mock_integration_response_params
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_put_integration_dynamodb_proxy_validation_with_request_template
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_put_integration_dynamodb_proxy_validation_without_request_template
tests.aws.services.apigateway.test_apigateway_basic.TestIntegrations ‑ test_api_gateway_http_integrations[custom]
…

tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayGatewayResponse ‑ test_gateway_response_put
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_create_rest_api_with_custom_id[localstack_path_based_url]
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_invoke_endpoint_cors_headers[http://allowed-False-UrlType.LS_PATH_BASED]
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_invoke_endpoint_cors_headers[http://allowed-True-UrlType.LS_PATH_BASED]
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_invoke_endpoint_cors_headers[http://denied-False-UrlType.LS_PATH_BASED]
tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_invoke_endpoint_cors_headers[http://denied-True-UrlType.LS_PATH_BASED]
tests.aws.services.apigateway.test_apigateway_common.TestApiGatewayCommon ‑ test_invocation_trace_id
tests.aws.services.apigateway.test_apigateway_common.TestApigatewayRouting ‑ test_routing_not_found
tests.aws.services.apigateway.test_apigateway_http ‑ test_http_proxy_integration_request_data_mappings
tests.aws.services.apigateway.test_apigateway_integrations ‑ test_integration_mock_with_path_param
…

♻️ This comment has been updated with latest results.

@dominikschubert dominikschubert marked this pull request as ready for review November 14, 2024 16:53
@dominikschubert dominikschubert merged commit 6ffc483 into master Nov 14, 2024
43 of 44 checks passed
@dominikschubert dominikschubert deleted the release/v4 branch November 14, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MEPalma MEPalma Awaiting requested review from MEPalma MEPalma is a code owner

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

@bentsku bentsku Awaiting requested review from bentsku bentsku is a code owner

@dfangl dfangl Awaiting requested review from dfangl dfangl is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

@thrau thrau Awaiting requested review from thrau thrau is a code owner

Assignees

@dominikschubert dominikschubert

@alexrashed alexrashed

Labels
semver: major Breaking changes which can be included in a major release only
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
8 participants
@alexrashed @localstack-bot @bentsku @dominikschubert @joe4dev @dfangl @gtsiolis @viren-nadkarni