drop support for Python 3.8 in the LocalStack CLI #11875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
bentsku
approved these changes
Nov 19, 2024
Comment on lines
+337
to
+340
| with ( | ||
| self._s3_store.open(src_bucket, src_s3_object, mode="r") as src_stored_object, | ||
| self.open(s3_part, mode="w") as stored_part, | ||
| ): |
There was a problem hiding this comment.
I was super curious about this, so here it is for history:
https://www.blog.pythonlibrary.org/2021/09/08/python-3-10-parenthesized-context-managers/
Super neat! 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
With v4 we will be dropping the support for Python 3.8 in our LocalStack CLI.
It reached its End Of Life on the 7th of October 2024 and does not get any updates anymore (not even security).
Changes
Similar to #9148, this PR bumps the minimum version in the
pyproject.toml(+ in the ruff config), and removes 3.8 from the CLI test build matrix and adds 3.13 instead.