Skip to content

drop support for Python 3.7 #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 19, 2023
Merged

drop support for Python 3.7 #9148

merged 5 commits into from
Sep 19, 2023

Conversation

alexrashed
Copy link
Member

Motivation

As announced in #8827, we are going to drop Python 3.7 support with the next minor release 2.3.
This PR drops the tests and updates a bit of the code.

Changes

  • Updates the README to define the minimum python version to be 3.8.
  • Drops the CLI tests for 3.7.
  • Drops some dependency restrictions for Python < 3.8
    • This is debatable, it will most likely break 3.7 compatibility right away.
  • Removes some 3.7-specific checks in the tests.

@alexrashed alexrashed added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Sep 14, 2023
@alexrashed alexrashed added this to the 2.3 milestone Sep 14, 2023
@alexrashed alexrashed requested a review from thrau as a code owner September 14, 2023 13:18
@alexrashed alexrashed self-assigned this Sep 14, 2023
@alexrashed alexrashed requested a review from dfangl as a code owner September 14, 2023 13:18
thrau
thrau approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@thrau thrau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i suppose removing all instances of

if sys.version_info >= (3, 8):
    from typing import TypedDict
else:
    from typing_extensions import TypedDict

and similar will be a future PR! :-)

@coveralls
Copy link

coveralls commented Sep 14, 2023 •
edited
Loading

Coverage Status

coverage: 80.065% (-0.006%) from 80.071% when pulling 416c149 on drop-python-3.7 into 7305e58 on master.

@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

LocalStack Community integration with Pro

       2 files  ±0         2 suites  ±0   1h 24m 11s ⏱️ + 11m 19s
2 213 tests ±0  1 717 ✔️ ±0  496 💤 ±0  0 ❌ ±0 
2 214 runs  ±0  1 717 ✔️ ±0  497 💤 ±0  0 ❌ ±0 

Results for commit 416c149. ± Comparison against base commit 7305e58.

♻️ This comment has been updated with latest results.

@dfangl
Copy link
Member

dfangl commented Sep 14, 2023

Do we want to enforce this as well? There is https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#python-requires , which prevents pip from installing a this version by default. So, someone with python 3.7, would get stuck on version 2.2. You can override it in pip, though.

@alexrashed
Copy link
Member Author

In the last 4 commits I added the following changes:

  • add python_requires to setup.cfg as suggested by @dfangl
  • git rid of all the sys.version_info checks by:
    • updating the ASF scaffold
    • regenerating all the APIs (this is why we have so many codeowner reviewers now, sorry for the ping!)
    • manually removing all the remaining checks

dfangl
dfangl approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alexrashed alexrashed merged commit 2f05247 into master Sep 19, 2023
@alexrashed alexrashed deleted the drop-python-3.7 branch September 19, 2023 11:38
@alexrashed alexrashed mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrau thrau thrau approved these changes

@dfangl dfangl dfangl approved these changes

@sannya-singal sannya-singal Awaiting requested review from sannya-singal

@ackdav ackdav Awaiting requested review from ackdav

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@MEPalma MEPalma Awaiting requested review from MEPalma

@baermat baermat Awaiting requested review from baermat

@bentsku bentsku Awaiting requested review from bentsku

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni

@macnev2013 macnev2013 Awaiting requested review from macnev2013

@giograno giograno Awaiting requested review from giograno

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@steffyP steffyP Awaiting requested review from steffyP

@joe4dev joe4dev Awaiting requested review from joe4dev

@pinzon pinzon Awaiting requested review from pinzon

@simonrw simonrw Awaiting requested review from simonrw

@calvernaz calvernaz Awaiting requested review from calvernaz

Assignees

@alexrashed alexrashed

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@alexrashed @coveralls @dfangl @thrau