Skip to content

fixed java lib path for macos #11892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

fixed java lib path for macos #11892

merged 1 commit into from
Nov 27, 2024

Conversation

macnev2013
Copy link
Contributor

Motivation

This is a follow up PR to #11888 (comment). @maxhoheiser reported a bug where java lib path was not properly generated.

Thanks @maxhoheiser for reporting.

Changes

  • Updated java lib path for macos to not include /Contents/Home since it's already included in the java home.

@macnev2013 macnev2013 requested review from viren-nadkarni and alexrashed and removed request for alexrashed November 21, 2024 10:53
@macnev2013 macnev2013 added the semver: patch Non-breaking changes which can be included in patch releases label Nov 21, 2024
viren-nadkarni
viren-nadkarni reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac JRE builds seem to have a different file tree altogether. Have you checked if the paths on line 70 and 72 for example are valid with this change?

@macnev2013
Copy link
Contributor Author

Yes @viren-nadkarni, Since we've directly updated the JAVA_HOME, all the variables are updated accordingly.

e.g: For ld_library_path we are just adding {java_home}/lib (which already includes correct path for mac)

@alexrashed alexrashed added this to the 4.0.1 milestone Nov 21, 2024
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 45m 19s ⏱️ + 3m 41s
3 565 tests ±0  3 229 ✅ ±0  336 💤 ±0  0 ❌ ±0 
3 567 runs  ±0  3 229 ✅ ±0  338 💤 ±0  0 ❌ ±0 

Results for commit 73f6275. ± Comparison against base commit 6748e0e.

@macnev2013 macnev2013 marked this pull request as ready for review November 21, 2024 12:11
@dominikschubert dominikschubert modified the milestones: 4.0.1, 4.0.2 Nov 22, 2024
@bentsku bentsku modified the milestones: 4.0.2, 4.0.3 Nov 25, 2024
@macnev2013 macnev2013 merged commit 04c02da into master Nov 27, 2024
35 of 36 checks passed
@macnev2013 macnev2013 deleted the fix/java-lib branch November 27, 2024 10:37
@joe4dev joe4dev mentioned this pull request Nov 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed is a code owner

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@macnev2013 @viren-nadkarni @dominikschubert @alexrashed @bentsku