Skip to content

Handle null value in SES OpenAPI spec #11954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2024
Merged

Handle null value in SES OpenAPI spec #11954

merged 2 commits into from
Nov 29, 2024

Conversation

giograno
Copy link
Member

Motivation

This PR fixes a minor gap in our SES OpenAPI specs.
In particular, the htlm_part property in the response to GET /_aws/ses can be null.
This issue was detected by @HarshCasper when using the SDK generated from the spec (as the generated Pydantic model does not expect a null value).

Changes

  • Change html_part to nullable in the specs.

@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 48m 21s ⏱️ -42s
3 775 tests ±0  3 429 ✅ ±0  346 💤 ±0  0 ❌ ±0 
3 777 runs  ±0  3 429 ✅ ±0  348 💤 ±0  0 ❌ ±0 

Results for commit 215f5d2. ± Comparison against base commit 0e01610.

♻️ This comment has been updated with latest results.

@giograno giograno marked this pull request as ready for review November 28, 2024 03:19
viren-nadkarni
viren-nadkarni reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

Small ask: could you also update the class definition in localstack.services.ses.models before merging?

viren-nadkarni
viren-nadkarni approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @giograno

@HarshCasper HarshCasper merged commit 2b405dc into master Nov 29, 2024
32 checks passed
@HarshCasper HarshCasper deleted the html-part-ses branch November 29, 2024 09:20
@bentsku bentsku added this to the 4.0.3 milestone Nov 29, 2024
@giograno giograno mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@HarshCasper HarshCasper HarshCasper approved these changes

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@giograno @viren-nadkarni @HarshCasper @bentsku