Skip to content

fix: follow-up for null value in SES response #11966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: follow-up for null value in SES response #11966

merged 1 commit into from
Nov 29, 2024

Conversation

giograno
Copy link
Member

@giograno giograno commented Nov 29, 2024 •
edited
Loading

Motivation

This PR is a follow-up fix for #11954.
It turns out that our code generator needs the change in this PR to output the right Pydantic model, i.e.,

class SesSentEmailBody(BaseModel):
    """
    SesSentEmailBody
    """ # noqa: E501
    html_part: Optional[StrictStr] = None
    text_part: StrictStr

Setting the type to null did not lead to the wanted generated code (i.e., html_part won't be optional).

Changes

  • Minor fix of the specs;

@giograno giograno added the semver: patch Non-breaking changes which can be included in patch releases label Nov 29, 2024
@giograno giograno added this to the 4.0.3 milestone Nov 29, 2024
bentsku
bentsku reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing this 👌

@giograno giograno marked this pull request as ready for review November 29, 2024 18:58
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 49m 41s ⏱️ +42s
3 816 tests ±0  3 498 ✅ ±0  318 💤 ±0  0 ❌ ±0 
3 818 runs  ±0  3 498 ✅ ±0  320 💤 ±0  0 ❌ ±0 

Results for commit 2a3867e. ± Comparison against base commit 21210ce.

@bentsku bentsku merged commit 52d4e4f into master Nov 29, 2024
42 checks passed
@bentsku bentsku deleted the ses-oas-followup branch November 29, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku bentsku left review comments

@viren-nadkarni viren-nadkarni Awaiting requested review from viren-nadkarni

Assignees
No one assigned
Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@giograno @bentsku