Skip to content

Add deprecation for Java-based event ruler #11964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add deprecation for Java-based event ruler #11964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion localstack-core/localstack/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,9 +846,10 @@ def populate_edge_configuration(
# get-function call.
INTERNAL_RESOURCE_ACCOUNT = os.environ.get("INTERNAL_RESOURCE_ACCOUNT") or "949334387222"

# TODO: remove with 4.1.0
# Determine which implementation to use for the event rule / event filtering engine used by multiple services:
# EventBridge, EventBridge Pipes, Lambda Event Source Mapping
# Options: python (default) | java (preview)
# Options: python (default) | java (deprecated since 4.0.3)
EVENT_RULE_ENGINE = os.environ.get("EVENT_RULE_ENGINE", "python").strip()

# -----
Expand Down
13 changes: 10 additions & 3 deletions localstack-core/localstack/deprecations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,11 @@ def is_affected(self) -> bool:
"0.14.0",
"This option has no effect anymore. Please use OPENSEARCH_ENDPOINT_STRATEGY instead.",
),
EnvVarDeprecation(
"PERSIST_ALL",
"2.3.2",
"LocalStack treats backends and assets the same with respect to persistence. Please remove PERSIST_ALL.",
),
EnvVarDeprecation(
"DNS_LOCAL_NAME_PATTERNS",
"3.0.0",
Expand Down Expand Up @@ -299,9 +304,11 @@ def is_affected(self) -> bool:
" Please remove PROVIDER_OVERRIDE_STEPFUNCTIONS.",
),
EnvVarDeprecation(
"PERSIST_ALL",
"2.3.2",
"LocalStack treats backends and assets the same with respect to persistence. Please remove PERSIST_ALL.",
"EVENT_RULE_ENGINE",
"4.0.3",
"The Java-based event ruler is deprecated because our latest Python-native implementation introduced in 4.0.3"
" is faster, achieves great AWS parity, and fixes compatibility issues with the StepFunctions JSONata feature."
" Please remove EVENT_RULE_ENGINE.",
),
]

Expand Down
2 changes: 0 additions & 2 deletions localstack-core/localstack/services/lambda_/event_source_mapping/pollers/poller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ class PipeStateReasonValues(PipeStateReason):
# TODO: add others (e.g., failure)


POLL_INTERVAL_SEC: float = 1

LOG = logging.getLogger(__name__)


Expand Down
Loading