Motivation

The latest botocore specs contain a new recursive type definition (RetrievalFilter -> RetrievalFilterList -> RetrievalFilter).
These new types have been added to botocore with boto/botocore@667d4c6, which landed in version 1.35.72.
This caused an issue with the ASF scaffolding because of an issue in the code generation for recursive types which also contain a Python keyword (due to not using quoted "forward types").
The resulting (faulty) code looked like this (mind the missing forward references in RetrievalFilter):

  RetrievalFilter = TypedDict(
      "RetrievalFilter",
      {
          "equals": Optional[FilterAttribute],
          ...
          "andAll": Optional[RetrievalFilterList],
          ...
      },
      total=False,
  )
  RetrievalFilterList = List[RetrievalFilter]
  
  class FilterValue(TypedDict, total=False):
      pass
  
  class FilterAttribute(TypedDict, total=False):
      key: FilterKey
      value: FilterValue

Changes

• Properly forwards the quote_types parameter in the code generation logic to ensure that the recursive type handling also works for exceptions and shapes with members named with Python keywords.

Testing

• Tested the ASF code generation for bedrock using botocore==1.35.72:

  pip install botocore==1.35.72
  python3 -m localstack.aws.scaffold generate bedrock
  

• Check that the resulting code is valid (uses forward references in RetrievalFilter):

  RetrievalFilter = TypedDict(
      "RetrievalFilter",
      {
          "equals": Optional["FilterAttribute"],
          "notEquals": Optional["FilterAttribute"],
          "greaterThan": Optional["FilterAttribute"],
          "greaterThanOrEquals": Optional["FilterAttribute"],
          "lessThan": Optional["FilterAttribute"],
          "lessThanOrEquals": Optional["FilterAttribute"],
          "in": Optional["FilterAttribute"],
          "notIn": Optional["FilterAttribute"],
          "startsWith": Optional["FilterAttribute"],
          "listContains": Optional["FilterAttribute"],
          "stringContains": Optional["FilterAttribute"],
          "andAll": Optional["RetrievalFilterList"],
          "orAll": Optional["RetrievalFilterList"],
      },
      total=False,
  )
  RetrievalFilterList = List[RetrievalFilter]
  
  
  class FilterValue(TypedDict, total=False):
      pass
  
  
  class FilterAttribute(TypedDict, total=False):
      key: FilterKey
      value: FilterValue