Skip to content

Refactor/events: Custom api destination and connection tests #11999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Refactor/events: Custom api destination and connection tests #11999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9351576
feat: move api destination and connection tests to separate test file
maxhoheiser Dec 6, 2024
5abc0d2
feat: move put event to api destination to target test file
maxhoheiser Dec 6, 2024
066ce1b
feat: update snapshots
maxhoheiser Dec 6, 2024
96e6016
fix: initiate fixture on class level
maxhoheiser Dec 9, 2024
2b6f510
refactor: align naming of target tests
maxhoheiser Dec 9, 2024
9d272f0
feat: use transformer defined in conftest
maxhoheiser Dec 9, 2024
74d0927
feat: update snapshots
maxhoheiser Dec 9, 2024
6b959f7
feat: skip api destination test for old provider
maxhoheiser Dec 9, 2024
382cc1c
fix: snapshot order changed
maxhoheiser Dec 13, 2024
f4d8f31
fix: auth test parameters
maxhoheiser Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions localstack-core/localstack/testing/snapshots/transformer_utility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,36 +744,6 @@ def stepfunctions_api():
# def custom(fn: Callable[[dict], dict]) -> Transformer:
# return GenericTransformer(fn)

@staticmethod
def eventbridge_api_destination(snapshot, connection_name: str):
"""
Add common transformers for EventBridge connection tests.

Args:
snapshot: The snapshot instance to add transformers to
connection_name: The name of the connection to transform in the snapshot
"""
snapshot.add_transformer(snapshot.transform.regex(connection_name, "<connection-name>"))
snapshot.add_transformer(
snapshot.transform.key_value("ApiDestinationArn", reference_replacement=False)
)
snapshot.add_transformer(
snapshot.transform.key_value("ConnectionArn", reference_replacement=False)
)
return snapshot

@staticmethod
def eventbridge_connection(snapshot, connection_name: str):
"""
Add common transformers for EventBridge connection tests.
Args:
snapshot: The snapshot instance to add transformers to
connection_name: The name of the connection to transform in the snapshot
"""
snapshot.add_transformer(snapshot.transform.regex(connection_name, "<connection-name>"))
snapshot.add_transformer(TransformerUtility.resource_name())
return snapshot


def _sns_pem_file_token_transformer(key: str, val: str) -> str:
if isinstance(val, str) and key.lower() == "SigningCertURL".lower():
Expand Down
29 changes: 29 additions & 0 deletions tests/aws/services/events/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import pytest

from localstack.testing.snapshots.transformer_utility import TransformerUtility
from localstack.utils.aws.arns import get_partition
from localstack.utils.strings import short_uid
from localstack.utils.sync import retry
Expand Down Expand Up @@ -445,3 +446,31 @@ def _create_api_destination(**kwargs):
)

return _create_api_destination


#############################
# Common Transformer Fixtures
#############################


@pytest.fixture
def api_destination_snapshot(snapshot, destination_name):
snapshot.add_transformers_list(
[
snapshot.transform.regex(destination_name, "<destination-name>"),
snapshot.transform.key_value("ApiDestinationArn", reference_replacement=False),
snapshot.transform.key_value("ConnectionArn", reference_replacement=False),
]
)
return snapshot


@pytest.fixture
def connection_snapshot(snapshot, connection_name):
snapshot.add_transformers_list(
[
snapshot.transform.regex(connection_name, "<connection-name>"),
TransformerUtility.resource_name(),
]
)
return snapshot
Loading
Loading