Skip to content

add cc methods for lambda function resource provider #12111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2025
Merged

add cc methods for lambda function resource provider #12111

merged 3 commits into from
Jan 20, 2025

Conversation

pinzon
Copy link
Member

@pinzon pinzon commented Jan 7, 2025

Motivation

This PR adds the methods READ and LIST to the AWS::Lambda:Function resource provider necessary for CloudControl

Changes

  • add read method
  • fix properties for list method

Testing

  • The testing is done in another PR

@pinzon pinzon added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 30m 45s ⏱️ - 20m 59s
3 026 tests  - 926  2 809 ✅  - 833  217 💤  - 92  0 ❌  - 1 
3 028 runs   - 926  2 809 ✅  - 833  219 💤  - 92  0 ❌  - 1 

Results for commit 4afae24. ± Comparison against base commit 4832016.

This pull request removes 926 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…
This pull request skips 1 test. 
tests.aws.services.s3.test_s3.TestS3PresignedUrl ‑ test_presigned_url_v4_x_amz_in_qs

♻️ This comment has been updated with latest results.

@pinzon pinzon marked this pull request as ready for review January 8, 2025 00:50
@pinzon pinzon force-pushed the cloudcontrol/lambda-function branch from bef05a2 to 242cccd Compare January 17, 2025 11:25
@pinzon
Copy link
Member Author

pinzon commented Jan 17, 2025

The test FAILED ../../localstack/tests/aws/services/s3/test_s3.py::TestS3PresignedUrl::test_presigned_url_v4_x_amz_in_qs - assert 400 == 200 is not related to this PR

joe4dev
joe4dev approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Shall we skip the failing S3 test and let @bentsku know, following our best practice R01?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

  2 files  ±0    2 suites  ±0   4m 14s ⏱️ +20s
441 tests ±0  389 ✅ ±0   52 💤 ±0  0 ❌ ±0 
882 runs  ±0  778 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 4afae24. ± Comparison against base commit 4832016.

♻️ This comment has been updated with latest results.

@pinzon pinzon merged commit 1edb594 into master Jan 20, 2025
38 checks passed
@pinzon pinzon deleted the cloudcontrol/lambda-function branch January 20, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe4dev joe4dev joe4dev approved these changes

Assignees
No one assigned
Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinzon @joe4dev