Skip to content

add cc methods for lambda function resource provider #12111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2025
Merged

add cc methods for lambda function resource provider #12111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
242cccd
add cc methods for lambda function resource provider
pinzon Jan 7, 2025
57649e8
skip flaky s3 test
pinzon Jan 20, 2025
4afae24
restore format
pinzon Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions localstack-core/localstack/services/lambda_/resource_providers/aws_lambda_function.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,30 @@ def _get_lambda_code_param(
return code


def _transform_function_to_model(function):
model_properties = [
"MemorySize",
"Description",
"TracingConfig",
"Timeout",
"Handler",
"SnapStartResponse",
"Role",
"FileSystemConfigs",
"FunctionName",
"Runtime",
"PackageType",
"LoggingConfig",
"Environment",
"Arn",
"EphemeralStorage",
"Architectures",
]
response_model = util.select_attributes(function, model_properties)
response_model["Arn"] = function["FunctionArn"]
return response_model


class LambdaFunctionProvider(ResourceProvider[LambdaFunctionProperties]):
TYPE = "AWS::Lambda::Function" # Autogenerated. Don't change
SCHEMA = util.get_schema_path(Path(__file__)) # Autogenerated. Don't change
Expand Down Expand Up @@ -407,7 +431,14 @@ def read(
- lambda:GetFunction
- lambda:GetFunctionCodeSigningConfig
"""
raise NotImplementedError
function_name = request.desired_state["FunctionName"]
lambda_client = request.aws_client_factory.lambda_
get_fn_response = lambda_client.get_function(FunctionName=function_name)

return ProgressEvent(
status=OperationStatus.SUCCESS,
resource_model=_transform_function_to_model(get_fn_response["Configuration"]),
)

def delete(
self,
Expand Down Expand Up @@ -521,5 +552,5 @@ def list(
functions = request.aws_client_factory.lambda_.list_functions()
return ProgressEvent(
status=OperationStatus.SUCCESS,
resource_models=[LambdaFunctionProperties(**fn) for fn in functions["Functions"]],
resource_models=[_transform_function_to_model(fn) for fn in functions["Functions"]],
)
1 change: 1 addition & 0 deletions tests/aws/services/s3/test_s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7488,6 +7488,7 @@ def test_presigned_url_signature_authentication_multi_part(
assert response.content == data

@pytest.mark.skipif(condition=TEST_S3_IMAGE, reason="Lambda not enabled in S3 image")
@pytest.mark.skip(reason="flaky")
@markers.aws.validated
def test_presigned_url_v4_x_amz_in_qs(
self,
Expand Down
Loading