S3: fix SSE-C parity error message #12162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 4m 45s ⏱️ Results for commit a073738. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 1h 0m 7s ⏱️ Results for commit a073738. ♻️ This comment has been updated with latest results. |
k-a-il
approved these changes
Jan 22, 2025
770bb93 to
a073738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up from #12145, where we had to updates all S3 snapshots. A few parity issues popped up, and this aims to fix them.
Seems like the error message for SSE-C related exception changes to be more explicit. This PR fixes that.
I've also updated the message for
HeadObject, but it seems the message is not serialized/parsed by Boto3. It cannot really hurt anyway 🤷Changes
HeadObjectrequest with noSSECustomerKeyMD5will trigger an error in AWS too