Skip to content

add tags to cfn read security groups #12408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

add tags to cfn read security groups #12408

merged 1 commit into from
Mar 19, 2025

Conversation

cloutierMat
Copy link
Contributor

Motivation

This pr adds tags to cloudformation read result on security groups.

@cloutierMat cloutierMat added aws:cloudformation AWS CloudFormation aws:ec2 Amazon Elastic Compute Cloud semver: patch Non-breaking changes which can be included in patch releases labels Mar 19, 2025
@cloutierMat cloutierMat self-assigned this Mar 19, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

 2 files  ±    0   2 suites  ±0   33s ⏱️ - 1h 51m 57s
23 tests  - 4 268  21 ✅  - 3 949  2 💤  - 319  0 ❌ ±0 
25 runs   - 4 268  21 ✅  - 3 949  4 💤  - 319  0 ❌ ±0 

Results for commit 7b15fda. ± Comparison against base commit fcc4de7.

This pull request removes 4268 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@cloutierMat cloutierMat marked this pull request as ready for review March 19, 2025 03:20
@cloutierMat cloutierMat requested a review from pinzon March 19, 2025 03:20
@viren-nadkarni viren-nadkarni removed their request for review March 19, 2025 10:04
pinzon
pinzon approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cloutierMat cloutierMat merged commit cf90cd4 into master Mar 19, 2025
37 of 38 checks passed
@cloutierMat cloutierMat deleted the cloudformation-add-tags-to-read branch March 19, 2025 16:57
@cloutierMat cloutierMat mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinzon pinzon pinzon approved these changes

@macnev2013 macnev2013 Awaiting requested review from macnev2013 macnev2013 is a code owner

Assignees

@cloutierMat cloutierMat

Labels
aws:cloudformation AWS CloudFormation aws:ec2 Amazon Elastic Compute Cloud semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloutierMat @pinzon