Skip to content

revert removal of get_resource_type method #12534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

revert removal of get_resource_type method #12534

merged 1 commit into from
Apr 17, 2025

Conversation

cloutierMat
Copy link
Contributor

@cloutierMat cloutierMat commented Apr 17, 2025 •
edited
Loading

Motivation

Changes from #12511 broke custom resources plugin loading in upstream repo.

Changes

  • Bring back usage of the method

@cloutierMat cloutierMat added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases labels Apr 17, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   21m 35s ⏱️ - 1h 32m 53s
460 tests  - 3 909  314 ✅  - 3 701  146 💤  - 208  0 ❌ ±0 
462 runs   - 3 909  314 ✅  - 3 701  148 💤  - 208  0 ❌ ±0 

Results for commit 299487d. ± Comparison against base commit ef8845d.

This pull request removes 3909 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@cloutierMat cloutierMat marked this pull request as ready for review April 17, 2025 03:15
dominikschubert
dominikschubert approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for unblocking this. We can look into another attempt at removing this at a later stage but since custom resources can be named arbitrarily with a Custom:: prefix this might be tricky

@simonrw simonrw merged commit 072c810 into master Apr 17, 2025
36 of 38 checks passed
@simonrw simonrw deleted the fix/cfn-custom-resource branch April 17, 2025 08:37
@simonrw simonrw mentioned this pull request Apr 22, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@pinzon pinzon Awaiting requested review from pinzon pinzon is a code owner

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

Assignees

@simonrw simonrw

@cloutierMat cloutierMat

Labels
aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cloutierMat @dominikschubert @simonrw