Skip to content

CFn: remove get_resource_type #12546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

CFn: remove get_resource_type #12546

wants to merge 3 commits into from

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Apr 22, 2025

Motivation

In a previous PR I incorrectly removed the get_resource_type function from CloudFormation. This broke CI for our private repository so the function was replaced in #12534.

This function is suitable for removal since it's not used in the private codebase, and it's API is a little strange.

Changes

Swap get_resource_type for standardise_resource_type which takes the resource type, and if it is a custom resource, standardise the name. Otherwise return the name unaffected.

Testing

  • Community testing should be enough as it's a core component of the CloudFormation engine
  • I will perform a manual run of our private CI to ensure we don't break that code base

@simonrw simonrw added the semver: patch Non-breaking changes which can be included in patch releases label Apr 22, 2025
@simonrw simonrw self-assigned this Apr 22, 2025
@github-actions GitHub Actions
Copy link

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   20m 22s ⏱️ - 1h 34m 22s
463 tests  - 3 910  314 ✅  - 3 702  149 💤  - 208  0 ❌ ±0 
465 runs   - 3 910  314 ✅  - 3 702  151 💤  - 208  0 ❌ ±0 

Results for commit eed67f3. ± Comparison against base commit 7e1e899.

This pull request removes 3910 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@simonrw simonrw added this to the Playground milestone Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

@pinzon pinzon Awaiting requested review from pinzon pinzon will be requested when the pull request is marked ready for review pinzon is a code owner

Assignees

@simonrw simonrw

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
Playground
Development

Successfully merging this pull request may close these issues.
1 participant
@simonrw