DDB Global table: add logic for streams #12641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c1fe2d to
c45289c
Compare
b5e0cd5 to
db15e4c
Compare
13b2900 to
f22abbb
Compare
viren-nadkarni
approved these changes
May 26, 2025
| @@ -33,6 +39,14 @@ def on_after_init(self): | |||
| def on_before_start(self): | |||
| self.server.start_dynamodb() | |||
|
|
|||
| def _forward_request( | |||
| self, context: RequestContext, region: str | None, service_request: ServiceRequest | |||
| ) -> ServiceResponse: | |||
There was a problem hiding this comment.
It would be nice to have a docstring explaining how this is different from self.forward_request()
3655b1b to
85f2231
Compare
Co-authored-by: Viren Nadkarni <viren.nadkarni@localstack.cloud>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In LocalStack, we support global DynamoDB tables by keeping track of the region of the original table and its replicas. Whenever we receive a request for a replica table, we redirect the request to the original region. Therefore, we do not really replicate any data, unlike AWS.
Global tables also come with associated streams. According to the docs, "each global table produces an independent stream based on all its writes, regardless of the origination point for those writes".
However, we did not implement any redirect logic for DynamoDB Streams, as the one I just described for DDB.
Changes
Changes have been implemented to both v1 and v2 providers.