re-introduce eager service loading #12657
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results - Preflight, Unit21 601 tests ±0 19 955 ✅ ±0 6m 13s ⏱️ +5s Results for commit 551b4ab. ± Comparison against base commit 893018f. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers597 tests 419 ✅ 14m 55s ⏱️ Results for commit 551b4ab. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 21m 20s ⏱️ Results for commit 551b4ab. ♻️ This comment has been updated with latest results. |
pinzon
reviewed
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seems we deleted eager service loading behavior with #11202 by accident.
Now with the new runtime framework, we can simply eager load services via hooks.
I've also added a proper bootstrap test to avoid deleting the behavior again without realizing it.
I updated the eager loading logic to not eager load all services if set, as it will most likely just wait forever.
My biggest question is where this hook declaration should live?
\cc @thrau @alexrashed
Changes