Skip to content

CloudFormation v2 Engine: Base Support for AWS::NoValue and Migration to Nothing Types #12668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 2, 2025
Merged

CloudFormation v2 Engine: Base Support for AWS::NoValue and Migration to Nothing Types #12668

merged 11 commits into from
Jun 2, 2025

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented May 27, 2025

* Extends #12662

Motivation

The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation offers no support for AWS::NoValue pseudo parameter.

Changes

  • Add base support for AWS::NoValue
  • Migrate type system in v2 engine to use Maybe and Nothing to signal missing values
  • Improve and fix the computation of ChangeType upon change set model construction
  • Unblock AWS::NoValue v1 tests

Future Work

Add further boundary tests for the use of AWS::NoValue during update sequences.

@MEPalma MEPalma added this to the 4.5 milestone May 27, 2025
@MEPalma MEPalma self-assigned this May 27, 2025
@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label May 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 593 tests  ±0   19 938 ✅ ±0   7m 1s ⏱️ +41s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 12e5705. ± Comparison against base commit 3d1a754.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 7s ⏱️ -4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 12e5705. ± Comparison against base commit 3d1a754.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

Test Results - Alternative Providers

971 tests   540 ✅  21m 45s ⏱️
  4 suites  431 💤
  4 files      0 ❌

Results for commit 12e5705.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files    2 suites   21m 44s ⏱️
870 tests 320 ✅ 550 💤 0 ❌
872 runs  320 ✅ 552 💤 0 ❌

Results for commit 12e5705.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 27, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 20m 58s ⏱️
5 198 tests 4 286 ✅ 912 💤 0 ❌
5 204 runs  4 286 ✅ 918 💤 0 ❌

Results for commit 12e5705.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma changed the base branch from master to transcribe-flaky-2 May 28, 2025 09:29
@MEPalma MEPalma changed the base branch from transcribe-flaky-2 to MEP-CFN-fn_transform May 28, 2025 09:34
@MEPalma MEPalma mentioned this pull request May 28, 2025
Merged
simonrw
simonrw approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 more passing tests, nice one

Base automatically changed from MEP-CFN-fn_transform to master June 2, 2025 11:19
@MEPalma MEPalma merged commit f732bc5 into master Jun 2, 2025
77 of 78 checks passed
@MEPalma MEPalma deleted the MEP-CFN-aws_novalue branch June 2, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @simonrw