Skip to content

CloudFormation v2 Engine: Support for Fn::Select #12679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jun 2, 2025
Merged

CloudFormation v2 Engine: Support for Fn::Select #12679

merged 12 commits into from
Jun 2, 2025
+2,652 −2

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented May 28, 2025

* Extends #12668

Motivation

The introduction of the CloudFormation v2 engine laid the foundation for a redesigned engine capable of accurately determining update requirements between CloudFormation deployments, while also enabling parallel execution during updates. However, the current implementation offers no support for Fn::Select.

Changes

  • Added change set modeling, description, and execution support for Fn::Select
  • Added an initial set of boundary tests for template updates concerning the use of Fn::Select
  • Unblocked or updated skip annotation for related v1 tests

@MEPalma MEPalma added this to the 4.5 milestone May 28, 2025
@MEPalma MEPalma requested a review from simonrw May 28, 2025 19:16
@MEPalma MEPalma self-assigned this May 28, 2025
@MEPalma MEPalma added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label May 28, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 593 tests  ±0   19 938 ✅ ±0   6m 18s ⏱️ +11s
     1 suites ±0    1 655 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit bd53423. ± Comparison against base commit f732bc5e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 11s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit bd53423. ± Comparison against base commit f732bc5e.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

Test Results - Alternative Providers

977 tests   547 ✅  21m 49s ⏱️
  4 suites  430 💤
  4 files      0 ❌

Results for commit bd53423.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files    2 suites   21m 45s ⏱️
876 tests 319 ✅ 557 💤 0 ❌
878 runs  319 ✅ 559 💤 0 ❌

Results for commit bd53423.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 21m 48s ⏱️
5 204 tests 4 285 ✅ 919 💤 0 ❌
5 210 runs  4 285 ✅ 925 💤 0 ❌

Results for commit bd53423.

♻️ This comment has been updated with latest results.

simonrw
simonrw approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these. These new intrinsic support prs are quite easy to follow and targeted. A testament to the stability of the core concept

@simonrw simonrw mentioned this pull request Jun 2, 2025
Draft
@MEPalma MEPalma mentioned this pull request Jun 2, 2025
Open
Base automatically changed from MEP-CFN-aws_novalue to master June 2, 2025 13:24
@MEPalma MEPalma merged commit a1684d2 into master Jun 2, 2025
57 checks passed
@MEPalma MEPalma deleted the MEP-CFN-fn_select branch June 2, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonrw simonrw simonrw approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
2 participants
@MEPalma @simonrw