Skip to content

Fix misnamed service_name attribute in stores #13094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2025
+3 −1
Merged

Fix misnamed service_name attribute in stores #13094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd27db
fix service_name attribute
giograno Sep 3, 2025
3e55df3
Add tests
viren-nadkarni Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion localstack-core/localstack/services/stores.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def __getitem__(self, region_name) -> BaseStoreType:

store_obj._global = self._global
store_obj._universal = self._universal
store_obj.service_name = self.service_name
store_obj._service_name = self.service_name
store_obj._account_id = self.account_id
store_obj._region_name = region_name

Expand Down
2 changes: 2 additions & 0 deletions tests/unit/test_stores.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,12 @@ def test_store_namespacing(self, sample_stores):
backend1_eu = sample_stores[account1][eu_region]
assert backend1_eu._account_id == account1
assert backend1_eu._region_name == eu_region
assert backend1_eu._service_name == "zzz"

backend1_ap = sample_stores[account1][ap_region]
assert backend1_ap._account_id == account1
assert backend1_ap._region_name == ap_region
assert backend1_ap._service_name == "zzz"

# Ensure region-specific data isolation
backend1_eu.region_specific_attr.extend([1, 2, 3])
Expand Down
Loading