Skip to content

[SFN] [ChoiceOperators] redesign, is operators, boolean equals operators, tests #7764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 3, 2023
Merged

[SFN] [ChoiceOperators] redesign, is operators, boolean equals operators, tests #7764

merged 11 commits into from
Apr 3, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Feb 28, 2023 •
edited
Loading

  • Improves the choice operation delegation strategy
  • Adds baseline implementation of Is* and BooleanEquals* operators
  • Adds testing setup/env
  • Adds tests for added operators

Note: logs a warning on invocations of IsTimestamp as AWS's behaviour can only be partially replicated at this time.

@MEPalma MEPalma self-assigned this Feb 28, 2023
@MEPalma MEPalma temporarily deployed to localstack-ext-tests February 28, 2023 13:28 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 28, 2023 •
edited
Loading

LocalStack integration with Pro

1 877 tests  +8   1 680 ✔️ ±0   1h 42m 47s ⏱️ + 18m 23s
       1 suites ±0      197 💤 +8 
       1 files   ±0          0 ❌ ±0 

Results for commit 8841b28. ± Comparison against base commit 8f196a0.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma mentioned this pull request Feb 28, 2023
Merged
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 1, 2023 09:20 — with GitHub Actions Inactive
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 1, 2023 09:36 — with GitHub Actions Inactive
@MEPalma MEPalma mentioned this pull request Mar 1, 2023
Merged
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 2, 2023 14:32 — with GitHub Actions Inactive
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 2, 2023 14:33 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Mar 2, 2023 •
edited
Loading

Coverage Status

Coverage: 81.895% (+0.02%) from 81.877% when pulling 8841b28 on MEP-sfn-choice-ops into 8f196a0 on master.

@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 2, 2023 16:54 — with GitHub Actions Inactive
@MEPalma MEPalma mentioned this pull request Mar 2, 2023
Merged
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 3, 2023 19:08 — with GitHub Actions Inactive
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 3, 2023 21:01 — with GitHub Actions Inactive
@dominikschubert dominikschubert self-requested a review March 9, 2023 18:36
dominikschubert
dominikschubert approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'd suggest adding a test for rfc3339 timestamps with a timezone as well, even if we don't yet support them

@MEPalma MEPalma merged commit a5e1e06 into master Apr 3, 2023
@alexrashed alexrashed deleted the MEP-sfn-choice-ops branch April 7, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@MEPalma MEPalma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MEPalma @coveralls @dominikschubert