Skip to content

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Feb 28, 2023

Extends MEP-sfn-choice-ops

  • Adds baseline implementation of Numeric* operators
  • Adds tests for added operators

@MEPalma MEPalma self-assigned this Feb 28, 2023
@MEPalma MEPalma temporarily deployed to localstack-ext-tests February 28, 2023 21:02 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Feb 28, 2023

LocalStack integration with Pro

1 887 tests  +10   1 680 ✔️ +1   1h 35m 46s ⏱️ + 12m 49s
       1 suites ±  0      207 💤 +9 
       1 files   ±  0          0 ±0 

Results for commit bce7649. ± Comparison against base commit a5e1e06.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 1, 2023 09:45 — with GitHub Actions Inactive
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 1, 2023 14:33 — with GitHub Actions Inactive
@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 2, 2023 14:32 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Mar 2, 2023

Coverage Status

Coverage: 82.051% (+0.05%) from 82.002% when pulling 55c10c9 on MEP-sfn-choice-ops-numeric into c73ff9f on master.

@MEPalma MEPalma temporarily deployed to localstack-ext-tests March 3, 2023 19:13 — with GitHub Actions Inactive
@MEPalma MEPalma marked this pull request as ready for review April 3, 2023 16:31
@MEPalma MEPalma requested a review from dominikschubert as a code owner April 3, 2023 16:31
@github-actions
Copy link

LocalStack Community integration with Pro

1 911 tests   1 699 ✔️  1h 12m 39s ⏱️
       2 suites     212 💤
       2 files           0

Results for commit 55c10c9.

Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -0,0 +1,139 @@
from typing import Any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the more condensed version here instead of splitting it into too many files 👍

@MEPalma MEPalma merged commit f3365b7 into master Apr 24, 2023
@MEPalma MEPalma deleted the MEP-sfn-choice-ops-numeric branch April 24, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants