Skip to content

[SFN] Failure support for aws-sdk #8033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 2, 2023
Merged

[SFN] Failure support for aws-sdk #8033

merged 10 commits into from
May 2, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Mar 31, 2023 •
edited
Loading

  • adds support for States.TaskFailed error handling in aws-sdk task states
  • fixes parsing of empty parameters declarations
  • fixes assumption of iam roles for snapshot tests
  • fixes event reporting for task workflows
  • adds error events
  • fixes encoding of environment input dumping
  • adds small snapshot tests for aws-sdk failing tasks
  • fixes the handling of States.Runtime errors, which cannot be caught

@MEPalma MEPalma self-assigned this Mar 31, 2023
@github-actions
Copy link

github-actions bot commented Apr 1, 2023 •
edited
Loading

LocalStack integration with Pro

1 893 tests   1 694 ✔️  1h 30m 47s ⏱️
       1 suites     199 💤
       1 files           0 ❌

Results for commit b45af30.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma marked this pull request as ready for review April 4, 2023 21:09
@MEPalma MEPalma requested a review from dominikschubert as a code owner April 4, 2023 21:09
@github-actions
Copy link

github-actions bot commented Apr 17, 2023 •
edited
Loading

LocalStack Community integration with Pro

1 908 tests  +2   1 701 ✔️ ±0   1h 12m 41s ⏱️ - 9m 16s
       2 suites ±0      207 💤 +2 
       2 files   ±0          0 ❌ ±0 

Results for commit 3b2a6c8. ± Comparison against base commit 66dd118.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma mentioned this pull request Apr 18, 2023
Merged
@coveralls
Copy link

coveralls commented Apr 18, 2023 •
edited
Loading

Coverage Status

Coverage: 82.123% (+0.0008%) from 82.122% when pulling ef0960f on MEP-sfn-errors-aws-sdk into 3716e92 on master.

@MEPalma MEPalma mentioned this pull request Apr 26, 2023
Merged
dominikschubert
dominikschubert approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Had a few nits first, but seems they are addressed in the follow-up PRs already 👍

@MEPalma MEPalma merged commit e38aa24 into master May 2, 2023
@alexrashed alexrashed deleted the MEP-sfn-errors-aws-sdk branch May 2, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@MEPalma MEPalma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MEPalma @coveralls @dominikschubert