Skip to content

[SFN] Failure support for lambda (service tasks) #8158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 5, 2023
Merged

[SFN] Failure support for lambda (service tasks) #8158

merged 15 commits into from
May 5, 2023

Conversation

MEPalma
Copy link
Contributor

@MEPalma MEPalma commented Apr 18, 2023 •
edited
Loading

* Extends #8033

This pr:

  • Restructures service state tasks, with lambda service state task and lambda state task now benefitting of this change
  • Fixes issues for which runtime failures not always lead to execution failure state events being logged
  • Fixed issue with result path not updating its target by value
  • Fixes relationship between catch declarations and catchers
  • Fixes States.TaskFailed matching task failure (see todo for further investigations)
  • Adds custom exception decorators for lambda errors
  • Adds baseline snapshot tests for lambda exceptions handling in catch declarations

@MEPalma MEPalma self-assigned this Apr 18, 2023
@coveralls
Copy link

coveralls commented Apr 18, 2023 •
edited
Loading

Coverage Status

Coverage: 82.159% (+0.05%) from 82.113% when pulling c5b1e7f on MEP-sfn-error-handling-lambda into c98afe4 on master.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited
Loading

LocalStack Community integration with Pro

1 960 tests   1 719 ✔️  1h 17m 4s ⏱️
       2 suites     241 💤
       2 files           0 ❌

Results for commit b6930ce.

♻️ This comment has been updated with latest results.

@MEPalma MEPalma marked this pull request as ready for review May 2, 2023 11:49
@MEPalma MEPalma requested a review from dominikschubert as a code owner May 2, 2023 11:49
dominikschubert
dominikschubert approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...unctions/asl/component/state/state_execution/state_task/service/state_task_service_lambda.py
def _eval_execution(self, env: Environment) -> None:
parameters = self._eval_parameters(env=env)
parameters_str = to_json_str(parameters)
env.event_history.add_event(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HistoryEventType.TaskScheduled might imply some changes needed in the future for the internals here where this isn't actually executed immediately but scheduled instead and might have to wait for resources to be available 🤔

@MEPalma MEPalma added type: feature New feature, or improvement to an existing feature semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases and removed type: feature New feature, or improvement to an existing feature labels May 5, 2023
@MEPalma MEPalma merged commit 8d11afa into master May 5, 2023
@MEPalma MEPalma deleted the MEP-sfn-error-handling-lambda branch May 7, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

Assignees

@MEPalma MEPalma

Labels
semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MEPalma @coveralls @dominikschubert