remove SNS create_sqs_message_attributes and add DLQ for Fifo topic #8144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on #8029. I actually only fixed the DLQ behaviour for FIFO topics for
publish_batchand not for a simplepublish.I've also refactored our way of passing argument to the SQS client in the publisher, to allow reuse between the regular SQS publisher and the batch one, also when sending it down the DLQ.
I've also removed
create_sqs_message_attributesas it was a remnant from theProxyListener, and now ASF properly decodes and casts theMessageBodyAttributeMapinto the right format. It might have been the issue for https://discuss.localstack.cloud/t/i-have-been-stuck-on-binascii-error-incorrect-padding-not-sure-if-it-is-an-error/297 but not sure yet, anyway, after testing, it was not used anymore.There's a follow up PR building on this to test and implement deduplication for FIFO topic, see #8145