SNS test and add deduplication for FIFO topic #8145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 14, 2023
045b1a6 to
f318e24
Compare
e934f58 to
b36c09e
Compare
f318e24 to
c109570
Compare
b36c09e to
1410817
Compare
e7db0f0 to
2058b65
Compare
c109570 to
95e65eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is building on top of #8144 and #8146, and adds test and implement the deduplication for FIFO topics. Right now, we are just properly using the SQS deduplication features, but SNS one is a bit different regarding the
MessageGroupId, see https://docs.aws.amazon.com/sns/latest/dg/fifo-message-dedup.html, the deduplication is at the topic level.We are also not storing the deduplication ID yet, so we cannot return the proper
MessageIdandSequenceNumberfrom the publishing call, which we should do.