Upgrade to pg@7 #312
Upgrade to pg@7 #312
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@slnode test please |
|
@robinbiondi, I'm working on dropping Node 0.10 and 0.12 in our tests through this PR: #313. After that, your PR should be good to go. |
|
@dhmlau Great! Thank you! |
|
@slnode test please |
|
@robinbiondi , I've dropped CI tests for Node 0.10 and 0.12 in #313. In order for this PR to reflect the new changes, you would need to make some changes in the PR. Rebasing PR (which you need to do anyway) might do the work, but if not, you'd need to make some changes to force the PR picking up the changes. |
|
@dhmlau Okay! I did rebase. It seems that the PR picked up the changes right ? Let me know |
|
@slnode test please |
|
@robinbiondi Thank you for your contribution! Looks like we have all the bases covered from https://node-postgres.com/guides/upgrading. |
There was a problem hiding this comment.
With regards to tests, it'd be great if you could backport our initialization test to the 2.x branch. See #296.
|
@b-admike Okay. But there is no file postgresql.initialization.test.js on 2.x. So what do you want me to backport ? |
|
@b-admike @dhmlau I took the initialization tests from 3.x and added them to my PR. |
|
@robinbiondi Thank you for including the test cases and creating the issue! We can follow up with that issue with another PR. I'm happy with this patch. @slnode test please |
|
@cadesalaberry , it's just released as |
|
Hey, @dhmlau this PR only makes sense for Would it be safe to use the |
|
@cadesalaberry, sorry that I didn't realize it was for 2.x when releasing it. You're right. The changes are now released as |
Description
Hello,
In this PR, we upgrade to pg@7 as it has been done on version 3.x
This fixes #311. (When a DB fail over, server goes down until restart)
Related issues
Checklist
guide