-
-
Notifications
You must be signed in to change notification settings - Fork 0
test(*): simplify describe blocks in test files #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes test suite descriptions for clarity across multiple packages and adds new test commands for targeted package testing.
- Simplifies describe block texts in test files by removing extraneous wording (e.g., "ok testing").
- Adds three new test commands in package.json for specific packages.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
tests/integration-binaries-permission/index.test.js | Updated describe block to a clear, concise name. |
tests/integration-api-esm/index.test.js | Simplified describe text; review the use of "integration-api-cjs" in an ESM folder. |
tests/integration-api-esm/index.test.cjs | Simplified describe block naming. |
tests/integration-api-cjs/index.test.mjs | Simplified describe block naming. |
tests/integration-api-cjs/index.test.js | Simplified describe block naming. |
packages/clang-format-node/src/utils/getClangFormatPath.test.js | Renamed test suite description to simply the function name. |
packages/clang-format-node/src/utils/clangFormatPath.test.js | Renamed test suite description for clarity. |
packages/clang-format-node/src/index.test.js | Updated describe block to a concise name. |
packages/clang-format-node/src/cli.test.js | Renamed describe block to "cli". |
packages/clang-format-git/src/utils/gitClangFormatPath.test.js | Renamed describe block to a concise name. |
packages/clang-format-git/src/utils/getGitClangFormatPath.test.js | Updated describe block to reflect the function name. |
packages/clang-format-git/src/index.test.js | Updated test description for clarity. |
packages/clang-format-git/src/cli.test.js | Simplified describe block naming. |
packages/clang-format-git-python/src/utils/gitClangFormatPath.test.js | Renamed describe block for clarity. |
packages/clang-format-git-python/src/index.test.js | Updated test description to a concise name. |
packages/clang-format-git-python/src/cli.test.js | Simplified describe block naming. |
package.json | Added new test commands for targeted package testing. |
Comments suppressed due to low confidence (1)
tests/integration-api-esm/index.test.js:40
- [nitpick] The test description mentions 'integration-api-cjs' while the file is located in an 'integration-api-esm' folder. Consider verifying that this naming accurately reflects the intended test context.
describe('integration-api-cjs ESM', () => {
Labels have been automatically applied based on the Conventional Commits specification.🏷️ |
Bundle ReportChanges will decrease total bundle size by 622.34kB (-50.79%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: website-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #331 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 439 439
=========================================
Hits 439 439 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…ch`) (#399) ## Release Information: `v1.3.4` New release of `lumirlumir/npm-clang-format-node` has arrived! 🎉 This PR bumps the package versions from `v1.3.3` to `v1.3.4` (`patch`). See [Actions](https://github.com/lumirlumir/npm-clang-format-node/actions/runs/16236437387) for more details. | Info | Value | | ----------- | -------------------------- | | Repository | `lumirlumir/npm-clang-format-node` | | SEMVER | `patch` | | Pre ID | `canary` | | Short SHA | 5862509 | | Old Version | `v1.3.3` | | New Version | `v1.3.4` | <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### 🐛 Bug Fixes * fix(*): update `postinstall` script to remove unnecessary build check by @lumirlumir in #398 ### 🧰 Chores * chore(*): update configuration files to use `.cjs` or `.mjs` extensions by @lumirlumir in #298 * chore(sync-server): update lint configs and bump package versions by @lumirlumir in #310 * chore(sync-server): update `lint-staged` and scripts by @lumirlumir in #314 * chore(sync-server): update `dependabot.yml` and `.gitignore` by @lumirlumir in #326 * chore(sync-server): remove `is-interactive` dependency and update Codecov configuration by @lumirlumir in #336 * chore(sync-server): update `dependabot.yml` by @lumirlumir in #351 * chore(*): run `npm dedupe` for cleanup by @lumirlumir in #362 * chore(*): remove `bananass-utils-vitepress` dependency by @lumirlumir in #377 * chore(*): move `FUNDING.yml` files to `.github` repository by @lumirlumir in #389 * chore(*): replace `shx` with native Node.js file operations in scripts by @lumirlumir in #397 ### 🔄 Continuous Integrations * ci(*): update actions to use docker native action by @lumirlumir in #393 * ci(*): update `test-cross-platform.yml` by @lumirlumir in #396 ### 🎨 Styles * style(*): clean up comments and remove unnecessary whitespace in multiple files by @lumirlumir in #380 ### 🧪 Tests * test(*): simplify describe blocks in test files by @lumirlumir in #331 ### ⬆️ Dependency Updates * chore(deps-dev): bump @types/node from 22.13.17 to 22.14.0 by @dependabot[bot] in #299 * chore(deps-dev): bump eslint-config-bananass from 0.0.6 to 0.0.7 in the bananass group across 1 directory by @dependabot[bot] in #300 * chore(deps-dev): bump eslint from 9.23.0 to 9.24.0 by @dependabot[bot] in #301 * chore(deps-dev): bump typescript from 5.8.2 to 5.8.3 by @dependabot[bot] in #302 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.3.8 to 1.4.1 by @dependabot[bot] in #303 * chore(deps-dev): bump lerna from 8.2.1 to 8.2.2 by @dependabot[bot] in #305 * chore(deps-dev): bump @types/node from 22.14.0 to 22.14.1 by @dependabot[bot] in #306 * chore(deps-dev): bump textlint-rule-allowed-uris from 1.0.9 to 1.1.0 by @dependabot[bot] in #308 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.4.1 to 1.5.1 by @dependabot[bot] in #307 * chore(deps-dev): bump lint-staged from 15.5.0 to 15.5.1 by @dependabot[bot] in #311 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.1 to 1.5.2 by @dependabot[bot] in #312 * chore(deps-dev): bump eslint from 9.24.0 to 9.25.0 by @dependabot[bot] in #315 * chore(deps-dev): bump eslint from 9.25.0 to 9.25.1 by @dependabot[bot] in #316 * chore(deps-dev): bump @types/node from 22.14.1 to 22.15.0 by @dependabot[bot] in #318 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #317 * chore(deps-dev): bump @types/node from 22.15.0 to 22.15.2 by @dependabot[bot] in #320 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #319 * chore(deps-dev): bump @types/node from 22.15.2 to 22.15.3 by @dependabot[bot] in #321 * chore(deps-dev): bump the babel group across 1 directory with 3 updates by @dependabot[bot] in #322 * chore(deps-dev): bump textlint from 14.6.0 to 14.7.1 by @dependabot[bot] in #323 * chore(deps-dev): bump eslint from 9.25.1 to 9.26.0 by @dependabot[bot] in #324 * chore(deps-dev): bump @types/node from 22.15.3 to 22.15.9 by @dependabot[bot] in #325 * chore(deps-dev): bump the babel group across 1 directory with 2 updates by @dependabot[bot] in #327 * chore(deps-dev): bump lint-staged from 15.5.1 to 15.5.2 by @dependabot[bot] in #328 * chore(deps-dev): bump @types/node from 22.15.9 to 22.15.15 by @dependabot[bot] in #330 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #332 * chore(deps-dev): bump @types/node from 22.15.16 to 22.15.17 by @dependabot[bot] in #333 * chore(deps-dev): bump lint-staged from 15.5.2 to 16.0.0 by @dependabot[bot] in #334 * chore(deps-dev): bump the bananass group across 2 directories with 3 updates by @dependabot[bot] in #335 * chore(deps): bump undici from 6.21.1 to 6.21.3 in the npm_and_yarn group across 1 directory by @dependabot[bot] in #340 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.2 to 1.5.5 by @dependabot[bot] in #341 * chore(deps-dev): bump @types/node from 22.15.17 to 22.15.18 by @dependabot[bot] in #338 * chore(deps-dev): bump eslint from 9.26.0 to 9.27.0 by @dependabot[bot] in #345 * chore(deps-dev): bump markdownlint-cli from 0.44.0 to 0.45.0 by @dependabot[bot] in #344 * chore(deps-dev): bump @codecov/vite-plugin from 1.9.0 to 1.9.1 by @dependabot[bot] in #346 * chore(deps-dev): bump the bananass group across 2 directories with 3 updates by @dependabot[bot] in #348 * chore(deps-dev): bump @types/node from 22.15.18 to 22.15.21 by @dependabot[bot] in #350 * chore(deps-dev): bump textlint from 14.7.1 to 14.7.2 by @dependabot[bot] in #349 * chore(deps-dev): bump @types/node from 22.15.21 to 22.15.24 by @dependabot[bot] in #354 * chore(deps-dev): bump @babel/core from 7.27.1 to 7.27.3 in the babel group across 1 directory by @dependabot[bot] in #352 * chore(deps-dev): bump @types/node from 22.15.24 to 22.15.26 by @dependabot[bot] in #355 * chore(deps-dev): bump lint-staged from 16.0.0 to 16.1.0 by @dependabot[bot] in #356 * chore(deps-dev): bump eslint from 9.27.0 to 9.28.0 by @dependabot[bot] in #358 * chore(deps-dev): bump @babel/core from 7.27.3 to 7.27.4 in the babel group across 1 directory by @dependabot[bot] in #357 * chore(deps-dev): bump @types/node from 22.15.26 to 22.15.29 by @dependabot[bot] in #359 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.5 to 1.6.0 by @dependabot[bot] in #360 * chore(deps-dev): bump the bananass group across 2 directories with 3 updates by @dependabot[bot] in #364 * chore(deps-dev): bump textlint-rule-allowed-uris from 1.1.0 to 1.1.1 by @dependabot[bot] in #366 * chore(deps-dev): bump @types/node from 22.15.29 to 24.0.0 by @dependabot[bot] in #367 * chore(deps-dev): bump @types/node from 24.0.0 to 24.0.1 by @dependabot[bot] in #368 * chore(deps-dev): bump eslint from 9.28.0 to 9.29.0 by @dependabot[bot] in #370 * chore(deps-dev): bump lint-staged from 16.1.0 to 16.1.2 by @dependabot[bot] in #369 * chore(deps-dev): bump @types/node from 24.0.1 to 24.0.3 by @dependabot[bot] in #371 * chore(deps-dev): bump concurrently from 9.1.2 to 9.2.0 by @dependabot[bot] in #372 * chore(deps-dev): bump prettier from 3.5.3 to 3.6.0 by @dependabot[bot] in #373 * chore(deps-dev): bump @babel/core from 7.27.4 to 7.27.7 in the babel group across 1 directory by @dependabot[bot] in #376 * chore(deps-dev): bump prettier from 3.6.0 to 3.6.2 by @dependabot[bot] in #378 * chore(deps-dev): bump eslint from 9.29.0 to 9.30.0 by @dependabot[bot] in #382 * chore(deps-dev): bump lerna from 8.2.2 to 8.2.3 by @dependabot[bot] in #381 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.6.0 to 1.6.1 by @dependabot[bot] in #383 * chore(deps-dev): bump @types/node from 24.0.3 to 24.0.8 by @dependabot[bot] in #385 * chore(deps-dev): bump @types/node from 24.0.8 to 24.0.10 by @dependabot[bot] in #387 * chore(deps-dev): bump eslint from 9.30.0 to 9.30.1 by @dependabot[bot] in #386 * chore(deps-dev): bump the babel group across 1 directory with 3 updates by @dependabot[bot] in #388 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #391 **Full Changelog**: v1.3.3...v1.3.4
This pull request introduces several changes across multiple packages to improve test descriptions and add new test commands to the
package.json
file. The key updates include standardizing test suite descriptions for clarity and adding specific test commands for individual packages.Updates to
package.json
:test:pkg:cfg
,test:pkg:cfgp
, andtest:pkg:cfn
to facilitate targeted testing ofclang-format-git
,clang-format-git-python
, andclang-format-node
respectively.Standardization of Test Descriptions:
describe
blocks in test files across multiple packages to simplify and standardize naming conventions:packages/clang-format-git-python
: Updated descriptions incli.test.js
,index.test.js
, andgitClangFormatPath.test.js
files. [1] [2] [3]packages/clang-format-git
: Updated descriptions incli.test.js
,index.test.js
,getGitClangFormatPath.test.js
, andgitClangFormatPath.test.js
files. [1] [2] [3] [4]packages/clang-format-node
: Updated descriptions incli.test.js
,index.test.js
,clangFormatPath.test.js
, andgetClangFormatPath.test.js
files. [1] [2] [3] [4]tests/integration-api-cjs
andtests/integration-api-esm
: Updated descriptions in both CommonJS and ESM test files. [1] [2] [3] [4]tests/integration-binaries-permission
: Updated description for the binaries permission test suite.