fix(*): update postinstall script to remove unnecessary build check
#398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Labels have been automatically applied based on the Conventional Commits specification.🏷️ |
There was a problem hiding this comment.
Pull Request Overview
Streamlines post-install scripts by removing unnecessary conditional build checks and ensures packages are built before testing in CI.
- Added a dedicated
Buildstep in the cross-platform workflow - Simplified
postinstallscripts in clang-format packages to always runchmod
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/test-cross-platform.yml | Added a Build step to run npm run build --if-present before packing |
| packages/clang-format-node/package.json | Simplified postinstall script to remove conditional src check |
| packages/clang-format-git/package.json | Simplified postinstall script to remove conditional src check |
| packages/clang-format-git-python/package.json | Simplified postinstall script to remove conditional src check |
Comments suppressed due to low confidence (4)
.github/workflows/test-cross-platform.yml:45
- [nitpick] Using
--if-presentcan mask missing build scripts. To explicitly build all workspace packages, consider usingnpm workspaces run buildso failures surface when a package is not configured properly.
run: npm run build --if-present
packages/clang-format-node/package.json:49
- Removing the conditional build check means that installing from source will no longer compile the code, leading to missing build artifacts. Consider ensuring built files are included in published packages or reintroducing a build step in the postinstall script.
"postinstall": "npm run chmod",
packages/clang-format-git/package.json:50
- Installing directly from the repo now skips the build step, so no
buildoutputs will be generated for local installs. If source installs must work, reintroduce an explicit build invocation or ensure prebuilt artifacts are shipped.
"postinstall": "npm run chmod",
packages/clang-format-git-python/package.json:51
- By always running
chmodand never building on install, local consumers of this package may experience missing compiled scripts. Confirm that all necessary files are included in the published package or restore a build step for source installs.
"postinstall": "npm run chmod",
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #398 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 422 422
=========================================
Hits 422 422 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
lumirlumir
added a commit
that referenced
this pull request
Jul 12, 2025
…ch`) (#399) ## Release Information: `v1.3.4` New release of `lumirlumir/npm-clang-format-node` has arrived! 🎉 This PR bumps the package versions from `v1.3.3` to `v1.3.4` (`patch`). See [Actions](https://github.com/lumirlumir/npm-clang-format-node/actions/runs/16236437387) for more details. | Info | Value | | ----------- | -------------------------- | | Repository | `lumirlumir/npm-clang-format-node` | | SEMVER | `patch` | | Pre ID | `canary` | | Short SHA | 5862509 | | Old Version | `v1.3.3` | | New Version | `v1.3.4` | <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### 🐛 Bug Fixes * fix(*): update `postinstall` script to remove unnecessary build check by @lumirlumir in #398 ### 🧰 Chores * chore(*): update configuration files to use `.cjs` or `.mjs` extensions by @lumirlumir in #298 * chore(sync-server): update lint configs and bump package versions by @lumirlumir in #310 * chore(sync-server): update `lint-staged` and scripts by @lumirlumir in #314 * chore(sync-server): update `dependabot.yml` and `.gitignore` by @lumirlumir in #326 * chore(sync-server): remove `is-interactive` dependency and update Codecov configuration by @lumirlumir in #336 * chore(sync-server): update `dependabot.yml` by @lumirlumir in #351 * chore(*): run `npm dedupe` for cleanup by @lumirlumir in #362 * chore(*): remove `bananass-utils-vitepress` dependency by @lumirlumir in #377 * chore(*): move `FUNDING.yml` files to `.github` repository by @lumirlumir in #389 * chore(*): replace `shx` with native Node.js file operations in scripts by @lumirlumir in #397 ### 🔄 Continuous Integrations * ci(*): update actions to use docker native action by @lumirlumir in #393 * ci(*): update `test-cross-platform.yml` by @lumirlumir in #396 ### 🎨 Styles * style(*): clean up comments and remove unnecessary whitespace in multiple files by @lumirlumir in #380 ### 🧪 Tests * test(*): simplify describe blocks in test files by @lumirlumir in #331 ### ⬆️ Dependency Updates * chore(deps-dev): bump @types/node from 22.13.17 to 22.14.0 by @dependabot[bot] in #299 * chore(deps-dev): bump eslint-config-bananass from 0.0.6 to 0.0.7 in the bananass group across 1 directory by @dependabot[bot] in #300 * chore(deps-dev): bump eslint from 9.23.0 to 9.24.0 by @dependabot[bot] in #301 * chore(deps-dev): bump typescript from 5.8.2 to 5.8.3 by @dependabot[bot] in #302 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.3.8 to 1.4.1 by @dependabot[bot] in #303 * chore(deps-dev): bump lerna from 8.2.1 to 8.2.2 by @dependabot[bot] in #305 * chore(deps-dev): bump @types/node from 22.14.0 to 22.14.1 by @dependabot[bot] in #306 * chore(deps-dev): bump textlint-rule-allowed-uris from 1.0.9 to 1.1.0 by @dependabot[bot] in #308 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.4.1 to 1.5.1 by @dependabot[bot] in #307 * chore(deps-dev): bump lint-staged from 15.5.0 to 15.5.1 by @dependabot[bot] in #311 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.1 to 1.5.2 by @dependabot[bot] in #312 * chore(deps-dev): bump eslint from 9.24.0 to 9.25.0 by @dependabot[bot] in #315 * chore(deps-dev): bump eslint from 9.25.0 to 9.25.1 by @dependabot[bot] in #316 * chore(deps-dev): bump @types/node from 22.14.1 to 22.15.0 by @dependabot[bot] in #318 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #317 * chore(deps-dev): bump @types/node from 22.15.0 to 22.15.2 by @dependabot[bot] in #320 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #319 * chore(deps-dev): bump @types/node from 22.15.2 to 22.15.3 by @dependabot[bot] in #321 * chore(deps-dev): bump the babel group across 1 directory with 3 updates by @dependabot[bot] in #322 * chore(deps-dev): bump textlint from 14.6.0 to 14.7.1 by @dependabot[bot] in #323 * chore(deps-dev): bump eslint from 9.25.1 to 9.26.0 by @dependabot[bot] in #324 * chore(deps-dev): bump @types/node from 22.15.3 to 22.15.9 by @dependabot[bot] in #325 * chore(deps-dev): bump the babel group across 1 directory with 2 updates by @dependabot[bot] in #327 * chore(deps-dev): bump lint-staged from 15.5.1 to 15.5.2 by @dependabot[bot] in #328 * chore(deps-dev): bump @types/node from 22.15.9 to 22.15.15 by @dependabot[bot] in #330 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #332 * chore(deps-dev): bump @types/node from 22.15.16 to 22.15.17 by @dependabot[bot] in #333 * chore(deps-dev): bump lint-staged from 15.5.2 to 16.0.0 by @dependabot[bot] in #334 * chore(deps-dev): bump the bananass group across 2 directories with 3 updates by @dependabot[bot] in #335 * chore(deps): bump undici from 6.21.1 to 6.21.3 in the npm_and_yarn group across 1 directory by @dependabot[bot] in #340 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.2 to 1.5.5 by @dependabot[bot] in #341 * chore(deps-dev): bump @types/node from 22.15.17 to 22.15.18 by @dependabot[bot] in #338 * chore(deps-dev): bump eslint from 9.26.0 to 9.27.0 by @dependabot[bot] in #345 * chore(deps-dev): bump markdownlint-cli from 0.44.0 to 0.45.0 by @dependabot[bot] in #344 * chore(deps-dev): bump @codecov/vite-plugin from 1.9.0 to 1.9.1 by @dependabot[bot] in #346 * chore(deps-dev): bump the bananass group across 2 directories with 3 updates by @dependabot[bot] in #348 * chore(deps-dev): bump @types/node from 22.15.18 to 22.15.21 by @dependabot[bot] in #350 * chore(deps-dev): bump textlint from 14.7.1 to 14.7.2 by @dependabot[bot] in #349 * chore(deps-dev): bump @types/node from 22.15.21 to 22.15.24 by @dependabot[bot] in #354 * chore(deps-dev): bump @babel/core from 7.27.1 to 7.27.3 in the babel group across 1 directory by @dependabot[bot] in #352 * chore(deps-dev): bump @types/node from 22.15.24 to 22.15.26 by @dependabot[bot] in #355 * chore(deps-dev): bump lint-staged from 16.0.0 to 16.1.0 by @dependabot[bot] in #356 * chore(deps-dev): bump eslint from 9.27.0 to 9.28.0 by @dependabot[bot] in #358 * chore(deps-dev): bump @babel/core from 7.27.3 to 7.27.4 in the babel group across 1 directory by @dependabot[bot] in #357 * chore(deps-dev): bump @types/node from 22.15.26 to 22.15.29 by @dependabot[bot] in #359 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.5.5 to 1.6.0 by @dependabot[bot] in #360 * chore(deps-dev): bump the bananass group across 2 directories with 3 updates by @dependabot[bot] in #364 * chore(deps-dev): bump textlint-rule-allowed-uris from 1.1.0 to 1.1.1 by @dependabot[bot] in #366 * chore(deps-dev): bump @types/node from 22.15.29 to 24.0.0 by @dependabot[bot] in #367 * chore(deps-dev): bump @types/node from 24.0.0 to 24.0.1 by @dependabot[bot] in #368 * chore(deps-dev): bump eslint from 9.28.0 to 9.29.0 by @dependabot[bot] in #370 * chore(deps-dev): bump lint-staged from 16.1.0 to 16.1.2 by @dependabot[bot] in #369 * chore(deps-dev): bump @types/node from 24.0.1 to 24.0.3 by @dependabot[bot] in #371 * chore(deps-dev): bump concurrently from 9.1.2 to 9.2.0 by @dependabot[bot] in #372 * chore(deps-dev): bump prettier from 3.5.3 to 3.6.0 by @dependabot[bot] in #373 * chore(deps-dev): bump @babel/core from 7.27.4 to 7.27.7 in the babel group across 1 directory by @dependabot[bot] in #376 * chore(deps-dev): bump prettier from 3.6.0 to 3.6.2 by @dependabot[bot] in #378 * chore(deps-dev): bump eslint from 9.29.0 to 9.30.0 by @dependabot[bot] in #382 * chore(deps-dev): bump lerna from 8.2.2 to 8.2.3 by @dependabot[bot] in #381 * chore(deps-dev): bump vitepress-plugin-group-icons from 1.6.0 to 1.6.1 by @dependabot[bot] in #383 * chore(deps-dev): bump @types/node from 24.0.3 to 24.0.8 by @dependabot[bot] in #385 * chore(deps-dev): bump @types/node from 24.0.8 to 24.0.10 by @dependabot[bot] in #387 * chore(deps-dev): bump eslint from 9.30.0 to 9.30.1 by @dependabot[bot] in #386 * chore(deps-dev): bump the babel group across 1 directory with 3 updates by @dependabot[bot] in #388 * chore(deps-dev): bump the bananass group across 1 directory with 2 updates by @dependabot[bot] in #391 **Full Changelog**: v1.3.3...v1.3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to streamline build processes and simplify post-installation scripts across multiple packages. The most notable updates include adding a build step to the cross-platform workflow and removing conditional checks in post-installation scripts for various packages.
Workflow improvements:
.github/workflows/test-cross-platform.yml: Added aBuildstep to the workflow to ensure packages are built before testing. ([.github/workflows/test-cross-platform.ymlR44-R46](https://github.com/lumirlumir/npm-clang-format-node/pull/398/files#diff-290907d9a4bcf13181105b134bd1645da5a3ef27c54f148ad5823e6b77e88426R44-R46))Simplification of post-installation scripts:
packages/clang-format-git-python/package.json: Simplified thepostinstallscript by removing the conditional check for thesrcdirectory and directly runningnpm run chmod. ([packages/clang-format-git-python/package.jsonL51-R51](https://github.com/lumirlumir/npm-clang-format-node/pull/398/files#diff-fb0eb5dba5b2656b3fdea4322c2ed2a691973f2e9ea536ce20b36c347ab1267eL51-R51))packages/clang-format-git/package.json: Updated thepostinstallscript to eliminate the conditional directory check, ensuringnpm run chmodis executed unconditionally. ([packages/clang-format-git/package.jsonL50-R50](https://github.com/lumirlumir/npm-clang-format-node/pull/398/files#diff-d85dcfb0934f579cff896723ab5eeb9a52668d2bb322338dddd93bc1241aa4f1L50-R50))packages/clang-format-node/package.json: Modified thepostinstallscript to remove the conditional logic and directly invokenpm run chmod. ([packages/clang-format-node/package.jsonL49-R49](https://github.com/lumirlumir/npm-clang-format-node/pull/398/files#diff-6e04d643c57b851ab02ad78e41531387d2cc01caf6c4cfbaa536aadd37346a30L49-R49))