-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Issues with jquery download caching #13450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
milestoned an 3.0.3 as 4de6dfb is on the PR into 2.2.x and the backport bot only needs to pull this back to 3.0.x. |
and in duplicating comments, I think the caching as the sha is ok (as users should put the files in the tree where they should be rather than rely on putting things in the right place in the cache) and the issue with freetype has PRs / commits to fix it. |
But for the case of FreeType that doesn't really work anymore (I think?)? Previously you could just have the tarball in the cache and we wouldn't try to download it, now you need to have the tarball renamed to the sha for that. |
The FreeType issue just above remains valid (well, at least unless @tacaswell explicitly dismisses it, which is fine with me too). |
Ah, I miss understood some of the bail logic, another PR coming. |
Looks like I missed two points when reviewing @tacaswell's parts of #11246: #11246 (review) and #11246 (review).
The text was updated successfully, but these errors were encountered: