Skip to content

Issues with jquery download caching #13450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anntzer opened this issue Feb 16, 2019 · 5 comments · Fixed by #13451 or #13455
Closed

Issues with jquery download caching #13450

anntzer opened this issue Feb 16, 2019 · 5 comments · Fixed by #13451 or #13455
Labels
Milestone

Comments

@anntzer
Copy link
Contributor

anntzer commented Feb 16, 2019

Looks like I missed two points when reviewing @tacaswell's parts of #11246: #11246 (review) and #11246 (review).

@anntzer anntzer added the Build label Feb 16, 2019
@anntzer anntzer added this to the v2.2.4 milestone Feb 16, 2019
@tacaswell tacaswell modified the milestones: v2.2.4, v3.0.3 Feb 17, 2019
tacaswell added a commit to tacaswell/matplotlib that referenced this issue Feb 17, 2019
@tacaswell
Copy link
Member

milestoned an 3.0.3 as 4de6dfb is on the PR into 2.2.x and the backport bot only needs to pull this back to 3.0.x.

@tacaswell
Copy link
Member

and in duplicating comments, I think the caching as the sha is ok (as users should put the files in the tree where they should be rather than rely on putting things in the right place in the cache) and the issue with freetype has PRs / commits to fix it.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 17, 2019

But for the case of FreeType that doesn't really work anymore (I think?)? Previously you could just have the tarball in the cache and we wouldn't try to download it, now you need to have the tarball renamed to the sha for that.

@anntzer
Copy link
Contributor Author

anntzer commented Feb 17, 2019

The FreeType issue just above remains valid (well, at least unless @tacaswell explicitly dismisses it, which is fine with me too).

@anntzer anntzer reopened this Feb 17, 2019
@tacaswell
Copy link
Member

Ah, I miss understood some of the bail logic, another PR coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants