Skip to content

[MNT]: AppVeyor not run on merging to main #26067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
oscargus opened this issue Jun 4, 2023 · 5 comments
Open

[MNT]: AppVeyor not run on merging to main #26067

oscargus opened this issue Jun 4, 2023 · 5 comments
Labels
CI: testing CI configuration and testing Maintenance

Comments

@oscargus
Copy link
Member

oscargus commented Jun 4, 2023

Summary

It seems like AppVeyor are only run on PRs, but not on merging to main. Hence, the code coverage is higher in the PRs than on main. This holds especially for Win32-specific parts of the code as well as Gtk4 (which looks more or less untested on main).

Proposed fix

Enable AppVeyor on merges to main.
@oscargus oscargus added Maintenance CI: testing CI configuration and testing labels Jun 4, 2023
@rcomer
Copy link
Member

rcomer commented Jun 4, 2023

Looking back through the last few commits, I think it is running but not on changes that fall under doc. Likely because we have this:

matplotlib/.appveyor.yml

Lines 12 to 16 in 19d93b7

skip_commits:
message: /\[ci doc\]/
files:
- doc/
- galleries/

We have similar for Github Actions and Azure, but in those cases the filter is specifically for PRs:

matplotlib/.github/workflows/tests.yml

Lines 12 to 20 in 19d93b7

pull_request:
branches-ignore:
- v[0-9]+.[0-9]+.[0-9x]+-doc
paths-ignore:
# Skip running tests if changes are only in documentation directories
- 'doc/**'
- 'galleries/examples/**'
- 'galleries/plot_types/**'
- 'galleries/tutorials/**'

matplotlib/azure-pipelines.yml

Lines 10 to 17 in 19d93b7

pr:
branches:
exclude:
- v*-doc
paths:
exclude:
- doc/**/*
- galleries/**/*

Maybe we need to also make the Appveyor skips specific to PRs.

@oscargus
Copy link
Member Author

oscargus commented Jun 4, 2023

Good spotting! One could think that we shouldn't run the other tests generating code coverage on doc changes? Although if that ends up with 0% coverage that is of course a worse scenario...

@rcomer
Copy link
Member

rcomer commented Jun 4, 2023

CodeCov has ways to account for skipped tests, but I think I only half understood it - #25391

@oscargus
Copy link
Member Author

oscargus commented Jun 4, 2023

Hmm , it seems like AppVeyor is the only one correctly skipping tests on doc-only changes?

@oscargus
Copy link
Member Author

oscargus commented Jun 4, 2023

Nah, both GitHub and Azure skips correctly for PRs, but not for main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI: testing CI configuration and testing Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscargus @rcomer