Skip to content

Size hint method in Qt backend should be named minimumSizeHint, not minumumSizeHint #28716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikhas opened this issue Aug 13, 2024 · 7 comments
Labels
Good first issue Open a pull request against these issues if there are no active ones!
Milestone

Comments

@mikhas
Copy link

mikhas commented Aug 13, 2024

def minumumSizeHint(self):

@tacaswell tacaswell added this to the v3.9.3 milestone Aug 15, 2024
@tacaswell tacaswell added the Good first issue Open a pull request against these issues if there are no active ones! label Aug 15, 2024
Copy link

Good first issue - notes for new contributors

This issue is suited to new contributors because it does not require understanding of the
Matplotlib internals. To get started, please see our contributing
guide
.

We do not assign issues. Check the Development section in the sidebar for linked pull
requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please
collaborate on the work by reviewing it rather than duplicating it in a competing PR.

If something is unclear, please reach out on any of our communication
channels
.

@tacaswell
Copy link
Member

task:

  • correct spelling of method name so Qt will use it!

@tacaswell
Copy link
Member

This typo appears to have come in via b7d1d59 in 2007 and been carried forward through all of the Qt refactors

@tacaswell
Copy link
Member

@mikhas
Copy link
Author

mikhas commented Aug 15, 2024

This typo appears to have come in via b7d1d59 in 2007 and been carried forward through all of the Qt refactors

I can't even tell what the effect is, given that the intended minimum size of width=10, height=10 appears to be too small (to me) anyway.

@tacaswell
Copy link
Member

We had a number of issues where we would end up with 0 pixel sized widgets that lead to crashes in the rasterizer. I suspect that the intent of the minimumSizeHint is to make sure Qt never squashes the widget all they way to 0 so the figure is always technically render able (if useless).

Given it has never worked, and we have other fixes for the issues it being missing caused, just removing it is also an option. However, I still lean towards "fix it".

@QuLogic
Copy link
Member

QuLogic commented Aug 16, 2024

Fixed by #28732.

@QuLogic QuLogic closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Open a pull request against these issues if there are no active ones!
Projects
None yet
Development

No branches or pull requests

3 participants