-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Size hint method in Qt backend should be named minimumSizeHint
, not minumumSizeHint
#28716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good first issue - notes for new contributorsThis issue is suited to new contributors because it does not require understanding of the We do not assign issues. Check the Development section in the sidebar for linked pull If something is unclear, please reach out on any of our communication |
task:
|
This typo appears to have come in via b7d1d59 in 2007 and been carried forward through all of the Qt refactors |
I can't even tell what the effect is, given that the intended minimum size of |
We had a number of issues where we would end up with 0 pixel sized widgets that lead to crashes in the rasterizer. I suspect that the intent of the minimumSizeHint is to make sure Qt never squashes the widget all they way to 0 so the figure is always technically render able (if useless). Given it has never worked, and we have other fixes for the issues it being missing caused, just removing it is also an option. However, I still lean towards "fix it". |
Fixed by #28732. |
matplotlib/lib/matplotlib/backends/backend_qt.py
Line 396 in 9f49b07
The text was updated successfully, but these errors were encountered: